I have been selected as the General Area Review Team (Gen-ART)
reviewer for this draft (for background on Gen-ART, please see
http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
Please resolve these comments along with any other Last Call comments
you may receive.
Document: draft-wilde-sms-uri-18.txt
Reviewer: Miguel Garcia <[email protected]>
Review Date: 12 Aug 2009
Summary: The draft is ready for publication as a standards track RFC.
I reviewed version -16 and -17 of this document raising a few issues. All
of the have been solved now. I only have some minor editorial comments.
Nits/editorial comments:
- In the ABNF of Section 2.2, the comment about the "body" is one line
above the introduction of "body", so the correct ABNF should be:
sms-field = sms-field-name "=" escaped-value
sms-field-name = "body" / sms-field-ext ; "body" MUST only
; appear once
(please be careful to avoid that "appear once" does not exceed the 72
characters limit).
- On a similar topic... I am not comfortable to see that a normative
statement such as "body MUST only appear once" is buried as a comment
(after the semicolon) in the ABNF. I would like to see this sentence as
a proper statement in the discussion that follows the ABNF, when the text
discuses the "body" <sms-field>.
- On Section 2.2, 3rd paragraph after the ABNF blob the first three
sentences include a high degree of redundancy and are somehow unordered.
How about this?
OLD:
SMS URIs may use additional fields, as indicated by the <sms-fields>
token. The only field defined here is the "body" <sms-field>.
Extensions to this specification MAY add additional fields.
NEW:
This specification defines a single <sms-field>: "body". Extentions
to this specification MAY define additional fields.
- Section 8.2 should be titled "Informative References".
/Miguel
--
Miguel A. Garcia
+34-91-339-3608
Ericsson Spain
_______________________________________________
Gen-art mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/gen-art
