Sounds good.
/Miguel
Erik Wilde wrote:
hello miguel.
thanks for the email, and thanks for reviewing the draft.
Document: draft-wilde-sms-uri-18.txt
Reviewer: Miguel Garcia <[email protected]>
Review Date: 12 Aug 2009
- In the ABNF of Section 2.2, the comment about the "body" is one line
above the introduction of "body", so the correct ABNF should be:
sms-field = sms-field-name "=" escaped-value
sms-field-name = "body" / sms-field-ext ; "body" MUST only
; appear once
(please be careful to avoid that "appear once" does not exceed the 72
characters limit).
i have moved the comment and it still fits the 72 character length limit.
- On a similar topic... I am not comfortable to see that a normative
statement such as "body MUST only appear once" is buried as a comment
(after the semicolon) in the ABNF. I would like to see this sentence
as a proper statement in the discussion that follows the ABNF, when
the text discuses the "body" <sms-field>.
that's a good point. the paragraph starting with:
'The "body" <sms-field> is used to define the body of the SMS message to
be composed.'
now starts with this (second sentence added to address your concerns):
'The "body" <sms-field> is used to define the body of the SMS message to
be composed. It MUST not appear more than once in an "sms" URI.'
- On Section 2.2, 3rd paragraph after the ABNF blob the first three
sentences include a high degree of redundancy and are somehow
unordered. How about this?
OLD:
SMS URIs may use additional fields, as indicated by the <sms-fields>
token. The only field defined here is the "body" <sms-field>.
Extensions to this specification MAY add additional fields.
NEW:
This specification defines a single <sms-field>: "body". Extentions
to this specification MAY define additional fields.
done.
- Section 8.2 should be titled "Informative References".
done. thanks and kind regards,
erik wilde tel:+1-510-6432253 - fax:+1-510-6425814
[email protected] - http://dret.net/netdret
UC Berkeley - School of Information (ISchool)
--
Miguel A. Garcia
+34-91-339-3608
Ericsson Spain
_______________________________________________
Gen-art mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/gen-art
