I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-imapmove-command-02 Reviewer: Kathleen Moriarty Review Date: IETF LC End Date: IESG Telechat date: (if known) Summary: The document needs a little more work before it is ready and should address what happens when the series of commands fails to execute (logging, revert, etc.). This should just result in either an incomplete copy (so maybe a garbled message or extra messages being left behind (expunge operations did not occur). This document does not cover that case and does not point to another standard that covers that question. Major issues: Minor issues: The security consideration section and the main body of the document do not explain what happens when the series of commands fails to execute or any associated risks. It should not result in mail being deleted, but rather being left in too many places or possible errors if the copy operation did not complete (unless that is handled and just needs a refernce)? Nits/editorial comments: Section 3.3 third paragraph: NOT and neither form a double negative, the phrase should use either instead of neither: The server MUST NOT leave a message in either mailbox In the last sentence of this same paragraph, is there a reference to what happens in the very last clause if the command fails? "Note that these restrictions only apply to individual messages and not to the command as a whole, which can fail partway through." Section 3.3 paragraph 5, can you add more context or clean up the paragraph to make it easier to follow: "Note that the server may send EXPUNGEs for other messages as well, if any happen to have been expunged at the same time; this is normal IMAP operation." Section 3.3, paragraph 6: remove duplicate "is allowed": Change from: "Note that moving a message to the currently selected mailbox (that is, where the source and target mailboxes are the same) is allowed when copying the message to the currently selected mailbox is allowed." TO: "Note that moving a message to the currently selected mailbox (that is, where the source and target mailboxes are the same) is allowed when copying the message to the currently selected mailbox." Section 4.3, last sentence: Replace 'that' with whatever it is referring to as it is not clear to the reader. "It can be unnecessarily difficult to process that usefully.)" Section 6, Security Considerations, second paragraph, last sentence (change with to when): Change from: "Scanning with updated rules may also be required when messages are moved even with the underlying policy has not changed. To: "Scanning with updated rules may also be required when messages are moved even when the underlying policy has not changed." Thanks, Kathleen _______________________________________________ Gen-art mailing list [email protected] https://www.ietf.org/mailman/listinfo/gen-art
