I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
Document: draft-ietf-rtgwg-rlfa-node-protection-09 Reviewer: Meral Shirazipour Review Date: 2017-11-16 IETF LC End Date: 2017-11-23 IESG Telechat date: NA Summary: This draft is ready to be published as Standards Track RFC but I have comments. Major issues: Minor issues: Nits/editorial comments: -please spell out acronyms at first use. -[Page 7,8] "If an implementation receives an unknown TLV type for the first TLV in a message, it SHOULD ignore and silently discard the TLV and any subsequent TLVs in the packet containing the TLV. If an implementation receives an unknown TLV type for a subsequent TLV within a message, it SHOULD ignore and silently discard the TLV. If the length of a TLV exceeds the available space in the containing packet, the implementation MUST ignore and silently discard the TLV and any remaining portion of the containing packet. Any data in the packet after the specified TLV length is considered to be outside the boundary of the TLV and MUST be ignored during processing of the TLV. " this whole paragraph is a bit confusing. e.g. "If an implementation receives an unknown TLV type for the first TLV in a message", is this refering to the header TLV? e.g. "If an implementation receives an unknown TLV type for a subsequent TLV within a message, it SHOULD ignore and silently discard the TLV.", does this mean TLVs after this one TLV should not be discarded? e.g. "Any data in the packet after the specified TLV length is considered to be outside the boundary of the TLV and MUST be ignored during processing of the TLV.", does this apply to last case only of when the length of a TLV exceeds the available space in the packet? -[Page 12, 13], "UNIX timeval" or timespec? (please verify if usec or nsec) -[Page 17], "An unique"--->"A unique" Best Regards, Meral --- Meral Shirazipour Ericsson Research www.ericsson.com
_______________________________________________ Gen-art mailing list [email protected] https://www.ietf.org/mailman/listinfo/gen-art
