On Fri, Feb 18, 2022 at 8:12 AM ethiejiesa via General <[email protected]> wrote: > Raul Miller <[email protected]> wrote: > > What is the point of subverting the git review system in this fashion? > > Not sure what you mean, exactly. The old PR is, well, old. It needs updates, > so > the tracking branch got a force-push to some new, beginning state. Another > option would be to open a separate PR, while closing the old one. Since the > original description is mostly still valid, and there were no comments on the > original code itself, I just opted to recycle the PR.
Ok... I don't like force push, though I understand it's occasionally necessary. But, I especially do not like force push to a non-functional state. And, I guess I expected the commits to be meaningful. For this drastic change, I think I would have done the work on a new branch, left a statement on the old branch or in the PR that it's being reworked and then -- if and when the new branch is ready, dealt with the deployment issues. That said, you're doing the work, and it's not my call. (But these are the kinds of concepts I was referring to when I asked that question in my last message.) Thanks, -- Raul ---------------------------------------------------------------------- For information about J forums see http://www.jsoftware.com/forums.htm
