Matei multiple TLPs using it as their main reviewing system? Outside of JClouds I am unaware of any others using it currently.
I think this is a good discussion to have, but we should start another thread with it so as to not hijack the Apache Spark graduation thread with it. -Jake On Thu, Feb 6, 2014 at 1:43 PM, Matei Zaharia <matei.zaha...@gmail.com>wrote: > I like the idea of sending these to the dev list. I'm going to open an > INFRA ticket for it. > > While it seems that the current web hook only sends events when a pull > request is opened or closed, GitHub *can* email watchers for comments as > well. I'm watching the project on GitHub and I get an email for every > comment, even on pull requests I never looked at. So maybe we can > investigate adding this to the GitHub hook -- I'm sure it's not a big burden > from their side. > > The other option would be to somehow subscribe dev@ through the standard > GitHub watcher framework by making it the notification address for some > account watching the repo, but this requires confirming the address and I > think anyone on dev might be able to unsubscribe it or take ownership of > that account if we do so. Maybe GitHub can help us do this without going > through the "confirm address" process. Did you guys have a contact over > there helping with the mirroring, or was it all done through their API? I > imagine it's in their interest to make GitHub work with the ASF process > because there are now multiple TLPs using it as their main reviewing system. > > Matei > > On Feb 6, 2014, at 10:13 AM, Jake Farrell <jfarr...@apache.org> wrote: > > > Once the mirror is setup and synced to github (24hr window for this > > potentially to occur) then one of the Github Apache org admins can setup > > the webhook. The project just needs to put in an infra ticket asking for > it > > > > -Jake > > > > > > > > On Thu, Feb 6, 2014 at 1:06 PM, Henry Saputra <henry.sapu...@gmail.com > >wrote: > > > >> HI Marvin, > >> > >> The automatic email to dev@ list for github mirror PR, does it happen > >> for all ASF github mirrors or each podling need to do some setup to > >> make it work? > >> > >> > >> - Henry > >> > >> On Thu, Feb 6, 2014 at 9:53 AM, Marvin Humphrey <mar...@rectangular.com > > > >> wrote: > >>> On Thu, Feb 6, 2014 at 9:08 AM, Michael Joyce <jo...@apache.org> > wrote: > >>>> How is doing a review on Github any different than doing a review on > >> Review > >>>> Board? > >>> > >>> One is captured to Apache controlled channels and the other is not. > >>> > >>>> If there's concern that work on Github isn't being adequately mirrored > >> on > >>>> the mailing lists then that sounds like an Infra problem to me. > >>> > >>> It's not an Infra problem. It's the problem of any PMC which fails to > >> ensure > >>> that all of its communications are properly archived. > >>> > >>> If anyone here is interested in contributing towards this feature, I > >> encourage > >>> you to subscribe to the infrastructure-dev@apache list. I also > >> encourage > >>> everyone to ponder carefully: > >>> > >>> * How to ensure that no information is lost when capturing > >> communications > >>> in GitHub channels through notifications to our dev lists. > >>> * The impact of adding GitHub integration features on long-term ASF > >> Infra > >>> labor costs. > >>> > >>>> There are plenty of hooks [1] that makes this easy to do and, if I'm > not > >>>> mistaken, pull requests through Github are already supposed to mail > dev@ > >> . > >>> > >>> That's right. I've actually worked on the specific hook that does > >> that[1][2]. > >>> > >>>> I would assume that any comment on them should as well. > >>> > >>> Why would you "assume" that GitHub comments are being mailed to dev > >> lists? > >>> They are not. > >>> > >>> Every Apache PMC member is tasked with oversight of their project, and > >> that > >>> includes ensuring that all decisions happen on the dev list and are > >> properly > >>> documented. It is not enough to "assume" that Infra is taking care of > >>> archival -- ensuring that the archival actually happens is the PMC's > >> direct > >>> responsibility. > >>> > >>> Marvin Humphrey > >>> > >>> [1] https://issues.apache.org/jira/browse/INFRA-4651 > >>> [2] Thread on legal-discuss@apache: http://s.apache.org/Nhx > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >>> For additional commands, e-mail: general-h...@incubator.apache.org > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> For additional commands, e-mail: general-h...@incubator.apache.org > >> > >> > >
