+1 (binding) On Wed, Jan 28, 2015 at 4:44 PM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 (binding) > > I checked (for both release artefacts): > - signatures and hashes all good > - incubating in source package name > - LICENSE and NOTICE good (but complex!) > - NOTICE has correct year > - no unexpected binary files (except in some test directories but that's > probably OK) > - all source files have correct headers > - can compile from source > - tests pass > > Some suggestions: > - Consider having separate licence and notice file for the binary release > - The NOTICE file is a little odd in that while it mentions what licenses > effect notice it doesn't list the software, but they are listed in the > license file. Perhaps take a look at what other projects have done. > > Thanks, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
--------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
