Hi,
-1 (binding) as LICENSE and NOTICE have issues, included files which have
Apache header when they are licensed under other terms, and binary connivence
files are missing required files (i.e. DISCLAIMER, LICENSE and NOTICE) Note
that the binary LICENSE and NOTICE file are very likely different to the the
source LICENSE and NOTICE files.
For the source release I checked:
- signatures ok but should be signed by apache.org address
- hashes good
- DISCLAIMER exists
- LICENSE and NOTICE have issues (see below)
- No unexpected binaries in source release
- All source files have Apache header
- Probably my setup/config but unable to compile from source and get this error:
FAILURE: Build failed with an exception.
* Where:
Script
'/Users/justinmclean/Downloads/ApacheGroovy/groovy-2.4.4/gradle/asciidoctor.gradle'
line: 19
* What went wrong:
A problem occurred evaluating script.
> Could not create task of type 'AsciidoctorTask'.
LICENSE and NOTICE issues:
- NOTICE contains items that are not required (as they are not bundled) and
it’s not in usual format
- LICENSE is missing:
- MIT licensed asciidoctor.org see /src/spec/assets/css/style.css
- MIT licensed normalize.css (in two places)
- BSD licensed FileNameCompleter.groovy which also has an Apache header
- LICENSE also contains several licenses/items that are not bundled and so
shouldn’t be included e.g. ANTLR 2, ASM 4, Hamcrest, JLine, JSR223, JUnit,
Multiverse
For binary releases:
- All are missing DISCLAIMER, LICENSE and NOTICE
Other issues:
- release candidate not in correct place
- not signed by apache.org address
- Short form of bundled licenses are preferred to long version
- all zips unzip to same directory
Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
