+1 (binding) > On Jul 13, 2015, at 10:23 AM, Emmanuel Lécharny <elecha...@gmail.com> wrote: > > Hi, > > my +1 (Binding), for the source package. > > Addressing Justin's issues : > > There *are* issues, but considering the security issue fixed in this > release, I'd rather have this version out. > > - The build scripts are failing because there are Windows file (^M at > the end of ech line). Removing them let you build the project. This has > to be fixed, though. > - NOTICE : not critical, IMO, but need to be fixed. > - LICENSE : I can't find the normalize.css file. The MIT & BSD license > should be added into LICENSE. The not bundled licenses should be removed. > > All in all, there are issues, that need to be addressed, and I expect > them to be fixed in the next release. > > Regarding the binary package, it has to contain the N&L files. I have > not checked it, because they are by-product, but that was a mistake > (obviously, people will use them instead of using the sources). I would > -1 the binary package as of today. > > Thanks ! > > Le 13/07/15 14:12, Justin Mclean a écrit : >> Hi, >> >> -1 (binding) as LICENSE and NOTICE have issues, included files which have >> Apache header when they are licensed under other terms, and binary >> connivence files are missing required files (i.e. DISCLAIMER, LICENSE and >> NOTICE) Note that the binary LICENSE and NOTICE file are very likely >> different to the the source LICENSE and NOTICE files. >> >> For the source release I checked: >> - signatures ok but should be signed by apache.org address >> - hashes good >> - DISCLAIMER exists >> - LICENSE and NOTICE have issues (see below) >> - No unexpected binaries in source release >> - All source files have Apache header >> - Probably my setup/config but unable to compile from source and get this >> error: >> >> FAILURE: Build failed with an exception. >> * Where: >> Script >> '/Users/justinmclean/Downloads/ApacheGroovy/groovy-2.4.4/gradle/asciidoctor.gradle' >> line: 19 >> * What went wrong: >> A problem occurred evaluating script. >>> Could not create task of type 'AsciidoctorTask'. >> LICENSE and NOTICE issues: >> - NOTICE contains items that are not required (as they are not bundled) and >> it’s not in usual format >> - LICENSE is missing: >> - MIT licensed asciidoctor.org see /src/spec/assets/css/style.css >> - MIT licensed normalize.css (in two places) >> - BSD licensed FileNameCompleter.groovy which also has an Apache header >> - LICENSE also contains several licenses/items that are not bundled and so >> shouldn’t be included e.g. ANTLR 2, ASM 4, Hamcrest, JLine, JSR223, JUnit, >> Multiverse >> >> For binary releases: >> - All are missing DISCLAIMER, LICENSE and NOTICE >> >> Other issues: >> - release candidate not in correct place >> - not signed by apache.org address >> - Short form of bundled licenses are preferred to long version >> - all zips unzip to same directory >> >> Thanks, >> Justin >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org >
--------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
