Hi,

+1 binding

I checked the source release.
- release contains incubating
- signatures and hashed good
- DISCLAIMER exists
- LICENSE and NOTICE good (a few minor issues)
- no unexpected binary files
- some source files are missing headers (see 
/usage/archetypes/quickstart/src/brooklyn-sample/src/test/java/com/acme/sample/brooklyn/sample/app/*.java)
- can compile from source

Minor issues:
- LICENCE is missing standard appendix
- probably no need for the full text of MIT and BSD as the short version is 
preferred and already used
- LICENSE is missing:
        riak (see 
./software/nosql/src/main/resources/brooklyn/entity/nosql/riak/vm.args + others)
        normalize.css (see 
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/mcasimir-mobile-angular-ui-be39011/dist/css/mobile-angular-ui-base.css)
        mobileangular-ui (see 
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/mcasimir-mobile-angular-ui-be39011/dist/js/mobile-angular-ui.js)
        r.js (see ./usage/jsgui/src/build/requirejs-maven-plugin/r.js)
        angular (see 
./sandbox/mobile-app/src/main/webapp/assets/mobile/libs/angular-1.2.19)

I didn’t have time to check the connivence binaries.

Thanks,
Justin


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to