Hi Josh, Thanks a lot for reviewing the RC and providing many useful comments.
I just have uploaded our KEY file to https://dist.apache.org/repos/dist/release/incubator/ratis/KEYS For the other issues, definitely will fix them in a later release. Tsz-Wo On 5/9/17, 8:26 AM, "Josh Elser" <els...@apache.org> wrote: +1 (binding) * sig/xsums OK * NOTICE ok, LICENSE is good enough (see below) * DISCLAIMER present * Incubating is in artifact name * Can build from source and could run tests * All of your additions to LICENSE (over "stock") are unnecessary. The trap you fell into is differentiating between what Ratis *depends* on and what Ratis *bundles*. You do not bundle protobuf, grpc, slf4j, etc, therefore you do not need to mention them in your release artifact. (If, at some point, Ratis releases a "binary" artifact that does include that software, you would need those entries in the LICENSE file bundled with that artifact) * The L&N files your bundle in your shaded jars (e.g. ratis-proto-shaded) are wrong for the opposite of the reason above (you include extra software but don't mention them in LICENSE/NOTICE). You should fix this for a later release. * Might you consider getting a website up for Ratis to help attract new community members? There's a template[1] which should make this much easier. * A `mvn package` on a fresh installation dirties the workspace, causing subsequent builds to fail on the RAT check on the file `ratis-0.1.0-alpha/ratis-proto-shaded/dependency-reduced-pom.xml`. You should configure the shade plugin to create this file in target/ When you finish the release, don't forget to populate a KEYS file in https://dist.apache.org/repos/dist/release/incubator/ratis. - Josh [1] https://github.com/apache/apache-website-template Tsz Wo Sze wrote: > Hi IPMC, > > The Apache Ratis community has voted and approved the proposal to > release Apache Ratis incubating Release 0.1.0-alpha rc0. We now > kindly request the Incubator PMC members to review and vote on this > source-only incubator release. > > Apache Ratis is an open source java implementation for RAFT consensus > protocol. RAFT is being used successfully as an alternative to Paxos > to implement a consistently replicated log. RAFT is proven to be safe > and is designed to be simpler to understand. > > [VOTE] Thread: > https://lists.apache.org/thread.html/f8a155337628018ee2ad1718c736c47d5dd3f2c2d4e7b1486ea9988b@%3Cdev.ratis.apache.org%3E > > [RESULT][VOTE] Thread: > https://lists.apache.org/thread.html/eb0df0548299ae98e68c0067e43d9747a67e92a459cedbe55b56425d@%3Cdev.ratis.apache.org%3E > > The git tag to be voted upon: > https://git-wip-us.apache.org/repos/asf?p=incubator-ratis.git;a=shortlog;h=refs/tags/ratis-0.1.0-alpha > > The git commit hash: > https://git-wip-us.apache.org/repos/asf?p=incubator-ratis.git;a=commit;h=52c4b6412df7daba82445db289f7b41e2216b4a6 > > The source tarball with signatures and hashes can be found at: > https://dist.apache.org/repos/dist/dev/incubator/ratis/0.1.0-alpha/rc0/ > > The fingerprint of key to sign release artifacts: > 2C33 A9CB 66AE AD59 3183 B01B 7843 4EF4 60D6 914B > > Release artifacts are signed with one of the keys available at: > https://dist.apache.org/repos/dist/dev/incubator/ratis/KEYS > > This vote will remain open for at least 72 hours. > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Obviously, I am +1 (non-binding). > > Regards, > Tsz-Wo > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
