--sorry, use my Apache account and sent it again.
Hi Justin, Thanks a lot for your checking. Ok, we will strictly follow license name to make it as License. We made big change since we bundled some 3rd party sources in our artifacts before, which was not right, so, we remove those JavaScript files(toaster, charts, etc). Those dependencies, declared in bower.js, will be installed when deploying in user box. We are not good at license issue, what is your advice for following two cases? 1 Not sure where this is right way to handle those JavaScript dependencies license issue as above. 2 How to handle background.jpg? Will remove asf header in treeview.js. Will file a ticket for this license thread. William ________________________________ From: William GUO <guo...@outlook.com> Sent: Tuesday, July 4, 2017 12:09:15 PM To: general@incubator.apache.org Cc: d...@griffin.incubator.apache.org Subject: Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1] Hi Justin, Thanks a lot for your checking. Ok, we will strictly follow license name to make it as License. We made big change since we bundled some 3rd party sources in our artifacts before, which was not right, so, we remove those JavaScript files(toaster, charts, etc). Those dependencies, declared in bower.js, will be installed when deploying in user box. We are not good at license issue, what is your advice for following two cases? 1 Not sure where this is right way to handle those JavaScript dependencies license issue as above. 2 How to handle background.jpg? Will remove asf header in treeview.js. Will file a ticket for this license thread. William On 7/4/17, 9:55 AM, "Justin Mclean" <jus...@classsoftware.com> wrote: Hi, Sorry -1 as the LICENSE file has not been fixed from last RC. The LICENSE file needs to be called LICENSE or LICENSE.txt and contain all 3rd party bundled licenses. [1][2] I’ll consider changing my vote if other IPMC members vote +1 on this and it fixed in the next release. I can see that LICENSE doesn’t contain any mention of 3rd party bundled code and that they are instead mentioned in LICENSE.md. I can see that LICENSE.md refers to 3rd party software that is no longer bundled in this RC i.e. angular toaster, charts, font awesome etc ect In fact it seems just about all 3rd party software has been removed except for [4] which incorrectly has an ASF header and is MIT licensed. Why the big change from last time? IS there any reason all this 3rd party software is no longer required? I checked: - name includes incubating - signature and hashes good - LICENSE has issues (see above) - NOTICE is good - no unexpected binary - source files have ASF headers - don’t check compile form source due to complex requirements/setup There are a couple of unresolved issues from the last RC - including for instance who own copyright on this file? [3] Has a JIRA been raised to sort these out? Thanks, Justin 1. http://www.apache.org/dev/apply-license.html#license-file-name 2. http://www.apache.org/legal/release-policy.html#license-file 3. ./ui/login/background.jpg 4. ./ui/js/directives/treeview.js --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org