hi Henry,
Just confirm , you mean ASF license header as below is wrong , after double check, I do see this ASF license header in griffin. I don't remember where this license comes from. Some files do have different ASF license header, as /*- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ we will make all as you mentioned if above is wrong. But we do need to figure our how to automate license header for different kinds of source code. Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. BTW, except above license issue, do you see any potential issue, so we can correct them together by next release candidate? Thanks, William ________________________________ From: Henry Saputra <henry.sapu...@gmail.com> Sent: Friday, July 7, 2017 2:37:07 AM To: general@incubator.apache.org Subject: Re: [VOTE] Release of Apache Griffin-0.1.5-incubating [rc2] -1 (binding) The source code has wrong ASF license header, it should use this one for code developed under ASF: https://www.apache.org/legal/src-headers.html - Henry On Wed, Jul 5, 2017 at 6:09 PM, William Guo <gu...@apache.org> wrote: > Hi all, > > This is a call for a vote on releasing Apache Griffin > 0.1.5-incubating, release candidate 2. This is the first release of > Griffin. > > Apache Griffin is data quality service for modern data system, it > defines a standard process to define, measure data quality for well-known > dimensions. With Apache Griffin, users will be able to quickly define their > data quality requirements and then get the result in near real time in > systematical approach. > > > Griffin vote thread > > https://lists.apache.org/thread.html/bb6d39a0cffc1265df5dc1db00d221 > 01ba85357242ce1efd5fedb854@%3Cdev.griffin.apache.org%3E > > > Griffin vote result thread > > https://lists.apache.org/thread.html/f7179ae14dd49bbbe23daf4e10b68b > 7a8662153d40ee03871febb1c4@%3Cdev.griffin.apache.org%3E > > We have cleaned up bundled software for license issues. > https://github.com/apache/incubator-griffin/blob/master/LICENSE.md > > > > The source tarball, including signatures, digests, etc. can be found > at: > https://dist.apache.org/repos/dist/dev/incubator/ > griffin/0.1.5-incubating > > > > The tag to be voted upon is 0.1.5-incubating: > https://git-wip-us.apache.org/repos/asf?p=incubator- > griffin.git;a=shortlog;h=refs/tags/0.1.5-incubating > > > > The release hash is 87f71017dc4bd925e309a540ca5783cf4c59dfff: > https://git-wip-us.apache.org/repos/asf?p=incubator- > griffin.git;a=commit;h=87f71017dc4bd925e309a540ca5783cf4c59dfff > > > The Nexus Staging URL: > https://repository.apache.org/content/repositories/ > orgapachegriffin-1005 > > > > Release artifacts are signed with the following key: > https://dist.apache.org/repos/dist/dev/incubator/griffin/KEYS > > > KEYS file available: > https://dist.apache.org/repos/dist/dev/incubator/griffin/KEYS > > > > For information about the contents of this release, see: > https://dist.apache.org/repos/dist/dev/incubator/ > griffin/0.1.5-incubating/CHANGES.txt > > > > Please vote on releasing this package as Apache Griffin > 0.1.5-incubating > > The vote will be open for 72 hours. > > [ ] +1 Release this package as Apache Griffin > ${RELEASE_VERSION}-incubating > [ ] +0 no opinion > [ ] -1 Do not release this package because ... > > Thanks, > William > ------------------------------ > *From:* William Guo <gu...@apache.org> > *Sent:* Thursday, July 6, 2017 8:46:25 AM > *To:* general@incubator.apache.org > *Cc:* jmcl...@apache.org; Henry Saputra; luke...@apache.org; > efrie...@cisco.com; kasper...@apache.org; umamah...@apache.org; > lrese...@apache.org > *Subject:* [VOTE] Release of Apache Griffin-0.1.5-incubating [rc2] > > Hi all, > > This is a call for a vote on releasing Apache Griffin > 0.1.5-incubating, release candidate 2. This is the first release of Griffin. > > Apache Griffin is data quality service for modern data system, it > defines a standard process to define, measure data quality for well-known > dimensions. With Apache Griffin, users will be able to quickly define their > data quality requirements and then get the result in near real time in > systematical approach. > > We have cleaned up bundled software for license issues. > https://github.com/apache/incubator-griffin/blob/master/LICENSE.md > > > > The source tarball, including signatures, digests, etc. can be found > at: > https://dist.apache.org/repos/dist/dev/incubator/griffin/0. > 1.5-incubating > > > > The tag to be voted upon is 0.1.5-incubating: > https://git-wip-us.apache.org/repos/asf?p=incubator-griffin. > git;a=shortlog;h=refs/tags/0.1.5-incubating > > > > The release hash is 87f71017dc4bd925e309a540ca5783cf4c59dfff: > https://git-wip-us.apache.org/repos/asf?p=incubator-griffin. > git;a=commit;h=87f71017dc4bd925e309a540ca5783cf4c59dfff > > > The Nexus Staging URL: > https://repository.apache.org/content/repositories/ > orgapachegriffin-1005 > > > > Release artifacts are signed with the following key: > https://dist.apache.org/repos/dist/dev/incubator/griffin/KEYS > > > KEYS file available: > https://dist.apache.org/repos/dist/dev/incubator/griffin/KEYS > > > > For information about the contents of this release, see: > https://dist.apache.org/repos/dist/dev/incubator/griffin/0. > 1.5-incubating/CHANGES.txt > > > > Please vote on releasing this package as Apache Griffin > 0.1.5-incubating > > The vote will be open for 72 hours. > > [ ] +1 Release this package as Apache Griffin > ${RELEASE_VERSION}-incubating > [ ] +0 no opinion > [ ] -1 Do not release this package because ... > > Thanks, > William > > > >