Hi Stian
I appreciate your very detail review for our release. I will move your points to the GitHub issue under `beta2` for helping the project to provide better release in next time. > Remember 72 hours is not a time-out, but a minimum period to wait. :) Yes. I know. I will be more patient :) And I got most of your points, and have one question. > For that reason the VOTE email should also include svn revision number from dist.apache.org, and/oor sha checksum of the files under vote. Assuming r26864 (from "svn log") aka sha512 checksums I understand in next time, we should add svn revision number. And do you suggest we should add checksum in the mail? Thank you very much. ------------------ Sheng Wu Apache SkyWalking ------------------ Original ------------------ From: "Stian Soiland-Reyes"<st...@apache.org>; Date: Mon, May 21, 2018 03:03 PM To: "???? Sheng Wu"<wu.sh...@foxmail.com>; Cc: "general"<general@incubator.apache.org>; Subject: Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-beta On Sun, 20 May 2018 17:08:31 +0800, "???? Sheng Wu" <wu.sh...@foxmail.com> wrote: > Hi, IPMC > I am asking the release vote, again. :) Haven't had one yet. Hope we can > have enough vote in 72 hours. Remember 72 hours is not a time-out, but a minimum period to wait. :) > Voting will start now (May 18th, 2018) and will remain open for at least 72 > hours, Request all IPMC members to give their vote. > [ ] +1 Release this package. > [ ] +0 No opinion. > [ ] -1 Do not release this package because??. My vote: +1 (binding) +1 gpg signatures verified +1 sha512 checksums correct +1 git commit matches -src.tgz +1 Release archive has -incubating in filename -1 Maven versions of submodules do NOT have -incubator or -incubating +1 Maven repo checksum matches binaries in dist +0 src/bin DISCLAIMER present, but it says "sponsored by Incubator" instead of "sponsored by the Apache Incubator PMC." +1 src LICENSE/NOTICE +1 bin zip vs .tar.gz +1 bin LICENSE - very good! +1 bin NOTICE +0 mvn clean package mostly builds (see below) build fails in apm-webapp because [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (validate) on project apm-webapp: Execution validate of goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.17 or one of its dependencies could not be resolved: Could not find artifact org.apache.skywalking:apm-checkstyle:jar:5.0.0-beta in central (https://repo.maven.apache.org/maven2) -> [Help 1] This is fixed by using "mvn install" instead within apm-checkstyle > Release Candidate: > *https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-beta/ I strongly recommend using suffixes like -RC1 in the release candidate URL and tag -- how do voters (and anyone checking the vote later) know if you happened to make a 'second 5.0.0-beta' release candidate? For that reason the VOTE email should also include svn revision number from dist.apache.org, and/oor sha checksum of the files under vote. Assuming r26864 (from "svn log") aka sha512 checksums 33b13cc7bc4ddea46d727ed8910c54c2e3b9acd6614a7f937e01e34ae6403942791ec3505d16de674605c665a4c0805271eb90a94775701d941462c530a99d11 apache-skywalking-apm-incubating-5.0.0-beta-src.tgz 770ad70ad3e23fbd93ea675528a81735848a92557f91036b23652b4c2a0282a7198bf9a09fd4570f8bef180d956e81e4f93a9c2308106de1b3d815feeb0dfd84 apache-skywalking-apm-incubating-5.0.0-beta.tar.gz d4ca36ed94a6d3557b747fe3ba3daf1dee5dca6d0f827af404762344c41214b4e5ff2173536e6c2feac383d9d0bdbaa648a5f0b8eee9f1b0913734d2c5adfffa apache-skywalking-apm-incubating-5.0.0-beta.zip > Maven 2 staging repository: > *https://repository.apache.org/content/repositories/orgapacheskywalking-1011/org/apache/skywalking/ > > Release Tag : > * v5.0.0-beta Should be v5.0.0-beta-RC1 (or later) while under vote, and then re-tagged once vote has been accepted. > Release CommitID : > * 5ddc4e714f2570421779a11f2589ffc32d2b8b21 (while incubating) please, include the URL of the git repository, particularly as skywalking is for some reason not in git.apache.org Assuming https://github.com/apache/incubator-skywalking/commit/5ddc4e714f2570421779a11f2589ffc32d2b8b21 and git submodules c02c12af12116121e25155d1f3fca0fadee5f2e9 apm-protocol/apm-network/src/main/proto (v1.1.1) 43ae106a15a77937a255c790a478c620b549d742 skywalking-ui (v5.0.0-alpha-44-g43ae106) which means that https://github.com/apache/incubator-skywalking-ui/commit/43ae106a15a77937a255c790a478c620b549d742 is also covered by this release vote. But 43ae106a15a77937a255c790a478c620b549d742 in skywalking-ui does not have a corresponding tag there. Presumably a v5.0.0-beta tag will be added there after successful vote. > Keys to verify the Release Candidate : > * http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x2EF5026E70A55777 > corresponding to pen...@apache.org +1 matches key from KEYS :) > Guide to build the release from source : > * > https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md Very good, thank you! --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
