Hi-
A few notes on the release package. Structure and contents look fine, but
I’ve included some suggestions on some of the supporting things
Git tag not signed. I dont think this is a hard requirement but is good practice
$ git tag -v v0.3.0-incubating-rc1
error: v0.3.0-incubating-rc1: cannot verify a non-tag object of type commit.
Commit is empty in dist/toree/VERSION (but is correct in the binary release)
$ cat dist/toree/VERSION
VERSION: 0.3.0-incubating
COMMIT:
Was not able to build from source using Vagrant, perhaps something is wrong
with my environment.
$ vagrant up
$ export USE_VAGRANT=true
$ make
....
Getting Scala 2.12.6 (for sbt)...
:: retrieving :: org.scala-sbt#boot-scala
confs: [default]
5 artifacts copied, 0 already retrieved (19632kB/72ms)
java.lang.UnsupportedClassVersionError: scala/Option : Unsupported major.minor
version 52.0
I checked:
- sigs and hashes good
- Licenses present and correct
- NOTICE file present
- No binary files
Thanks,
Eric
> On Nov 9, 2018, at 12:15 PM, Ryan Blue <[email protected]> wrote:
>
> +1 (binding, carried over from the podling vote)
>
> On Thu, Nov 8, 2018 at 7:54 PM Justin Mclean <[email protected]>
> wrote:
>
>> Hi,
>>
>> +1 (binding)
>>
>> I checked:
>> - incubating in name (although I notice the pip package doesn’t - is this
>> a limitation?)
>> - signatures and hashes all good
>> - DISCLAIMER exists
>> - LICENSE and NOTICE file
>> - all source files have ASF headers
>> - No binary files in release
>> - Can compile from source
>>
>> Thanks,
>> Justin
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>
>
> --
> Ryan Blue
> Software Engineer
> Netflix
