Hi Justin, I went through the license file to remove all licenses that no longer exist and tried to add any missing licenses I could find. I also tried to prune our rat-excludes for files that should be checked such as .js ones.
As for your comments: - 3rdparty/onnx-tensorrt itself has four different git submodules inside it which is the cause of the number of different licenses. I added the main license of each repo to our license file. - The src/operator files that you mention all have individual licenses that are located inside the file header (but are different than the apache license) For the CC-BY-SA content, we raised the issue on legal-discuss ( http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201805.mbox/%3CCAK1xzDdw_5-znx=y2wxvlwq_nk4ajmtfuqhp3dhr94wumqd...@mail.gmail.com%3E) and it seems to be somewhat acceptable for documentation similarly to how it is allowed for media. Can you help verify whether we have any release blocking problems that we still need to address in our license. Thanks, Zach On 2019/01/07 09:24:07, Hagay Lupesko <l...@gmail.com> wrote: > Thanks for clarifying Justin.> > > On Mon, Jan 7, 2019 at 1:06 AM Justin Mclean <ju...@classsoftware.com>> > wrote:> > > > Hi,> > >> > > > Good call. I will work with my colleagues in Amazon to try and help with> > > > this.> > >> > > Great if you need any help just ask.> > >> > > > I'm not sure what is the best approach with 3P code issues though: you> > > call> > > > out 3rdparty/onnx-tensorrt as having a mix of license types and having> > > > other issues. However, this is part of another repo, integrated into> > > MXNet> > > > as a git submodule (https://github.com/onnx/onnx-tensorrt.git).> > > > Is it necessary to "fix" licensing of 3P packages as well? I think this> > > > will be very difficult…> > >> > > Fixing downstream is good but not required, it all comes down to the> > > guiding principle [1]. You need to look inside and 3rd party code to see> > > what it contains and list all licenses that are bundled.> > >> > > A simple example is jQuery which is MIT licensed but includes MIT licensed> > > Sizzle so both of these need to mention in the LICENSE file.> > >> > > Thanks,> > > Justin> > >> > > 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle> > > ---------------------------------------------------------------------> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org> > > For additional commands, e-mail: general-h...@incubator.apache.org> > >> > >> >