Hi, +1 (binding)
I checked: - incubating in name - signature and hashes are fine - LICENSE is perhaps missing something e.g. license for [1] - NOTICE is fine - DISCLAIMER exists but please list why you are using the WIP disclaimer - No unexpected binary files - All source files have ASF headers - Unable to compile on OSX but assume that’s not a supported platform. It would be good to mention this in the README. You included “.git” directory in the source release was this intentional? It includes this file [1] which I’m not sure what the license is. You might also want to make this [2] be more in line with [3]. Thanks, Justin 1. .git/hooks/pre-rebase.sample 2. https://www.npmjs.com/org/annotator 3. https://cwiki.apache.org/confluence/display/INCUBATOR/Distribution+Guidelines --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
