+1 (binding)
I checked: - Incubating in name - Signatures and hashes - Disclaimer, LICENSE and NOTICE Thanks, -Jason On Tue, Aug 18, 2020 at 6:25 PM Michael Wall <mjw...@apache.org> wrote: > Thanks for the follow up Ciyong. You are right, -vv did not enable > verbose. If I had used -VV (with capital V's) I would have gotten > output. > > Good luck on the vote. > > Mike > > On Tue, Aug 18, 2020 at 2:43 AM Chen, Ciyong <ciyong.c...@intel.com> > wrote: > > > > Hi Michael, > > > > Thank you for your time to review and vote. > > > > Regarding your questions: > > > - Does anything with mshadow need to change now that it has passed > clearance. > > From source code release perspective, I don't think there's anything we > need to change as mshadow is already in the code base with the correct > license header. CC @Sheng to see if any comments. > > > > > - I tried running tests a couple of ways after the build I build but > they just hung for 15 min before I control-c'd them. Maybe I didn't wait > long enough, but there was no indication anything was running. > > The test suite contains lots of test cases which will be very time > consuming, " ctest -vv" doesn't enable the verbose output thus looks like > it hung as no output on the terminal. > > By using "ctest --verbose" which turns on the verbose and will give more > details for all the test cases. > > Currently, the entire test suite will run through many different > configurations of hardware and docker image via CI pipeline. > > > > Thanks, > > -Ciyong > > > > -----Original Message----- > > From: Michael Wall <mjw...@apache.org> > > Sent: Tuesday, August 18, 2020 9:54 AM > > To: general@incubator.apache.org > > Subject: Re: [VOTE] Release Apache MXNet (incubating) version 1.7.0.rc1 > > > > +1 from me > > > > Checked > > - signatures > > - incubating in name > > - License, Notice and Disclaimer > > - Compiled from source with CPP bindings using > https://mxnet.apache.org/versions/1.6/get_started/build_from_source#install-mxnet-for-python > , > > https://mxnet.apache.org/versions/1.6/get_started/cpp_setup and > https://github.com/apache/incubator-mxnet/blob/1.7.0.rc1/config/linux.cmake > > > > Couple of questions > > - Does anything with mshadow need to change now that it has passed > clearance. > > - I tried running tests a couple of ways after the build I build but > they just hung for 15 min before I control-c'd them. Maybe I didn't wait > long enough, but there was no indication anything was running. > > > > Here is the run > > > > ``` > > [0/1] Running tests... > > Test project > /home/mikewall/Desktop/mxnet-1.7.0/apache-mxnet-src-1.7.0.rc1-incubating/build > > Start 1: AllTestsInmxnetUnitTests > > ^Cninja: build stopped: interrupted by user. > > ``` > > > > And here is my history fwiw > > > > ``` > > sudo apt-get install -y build-essential git ninja-build ccache > libopenblas-dev libopencv-dev cp config/linux.cmake config.cmake rm -rf > build cmake -S. -Bbuild -DUSE_CPP_PACKAGE=1 -DCMAKE_BUILD_TYPE=Release > -GNinja cmake --build build cmake --build build --target test cd build && > ctest -vv ``` > > > > On Mon, Aug 17, 2020 at 2:27 PM Sheng Zha <zhash...@apache.org> wrote: > > > > > > Hi Justin, > > > > > > Since the blocking issue has been resolved, would you mind changing > your vote? Thanks. > > > > > > Regards, > > > Sheng > > > > > > On 2020/07/26 01:27:39, Justin Mclean <jus...@classsoftware.com> > wrote: > > > > Hi, > > > > > > > > -1 (binding) as this release contains code that hasn’t gone though > IP clearance (mshadow). > > > > > > > > I checked: > > > > - incubating in name > > > > - disclaimer exists > > > > - LICENSE and NOTICE have improved but I did not do an exhaustive > > > > check > > > > - No unexpected binary file > > > > - ASF files have ASF headers > > > > - unable to compile from source > > > > > > > > It also seems that this code may have been released before the > > > > PPMC/IPMC vote is over see [1][2][3][4] There are also branding and > > > > trademark issue with this site [5] This is in addition to the issues > > > > previously noted with releases, branding and trademarks.[6] > > > > > > > > Thanks, > > > > Justin > > > > > > > > > > > > 1. https://sourceforge.net/projects/apache-mxnet.mirror/ > > > > 2. > > > > https://repo.gradle.org/gradle/simple/repo/ai/djl/mxnet/mxnet-native > > > > -mkl/1.7.0-b/ 3. https://mvnrepository.com/artifact/ai.djl.mxnet > > > > 4. > > > > https://aur.archlinux.org/packages/?O=0&SeB=nd&K=mxnet&SB=v&SO=d&PP= > > > > 50&do_Search=Go > > > > 5. https://djl.ai > > > > 6. https://jira.apache.org/jira/browse/INCUBATOR-253 > > > > -------------------------------------------------------------------- > > > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
