The mikuli code was copied from cava prior to donation, looks like. That was 
three years ago, not sure how that happened or what to do about it.

We most definitely built all the sodium code, using a script as first pass then 
adding more docs and utilities.

> On Jun 14, 2021, at 11:19, Justin Mclean <jus...@classsoftware.com> wrote:
> 
> Hi,
> 
> I checked it mostly looks good  but I’m a little concerned but the code in 
> these directories [1][2] that have ASF headers but it looks like the code may 
> actually be from elsewhere. For instance compare [3] to [4]. Is this code 3rd 
> party code or based on 3rd party code? And if it is why does it have an ASF 
> header?
> 
> Thanks,
> Justin
> 
> 1. ./crypto/src/main/java/org/apache/tuweni/crypto/mikuli
> 2../crypto/src/main/java/org/apache/tuweni/crypto/sodium
> 3. ./crypto/src/main/java/org/apache/tuweni/crypto/mikuli/PublicKey.java
> 4. 
> https://github.com/ConsenSys/mikuli/blob/master/src/main/java/net/consensys/mikuli/crypto/PublicKey.java
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to