But at the same time, the file header has `/* from valgrind tests */`, I assumed you ported the variation of Valgrind.
A good practice is not to add more license information than you actually do, i.e., don't declare it's from valgrind tests if you believe you are using the original Public Domain sha1.c file, confusions arise like this. > On Feb 14, 2023, at 10:22, tison <wander4...@gmail.com> wrote: > > Hi zhenxu, > > When you look at the header, it writes: > > SHA-1 in C > By Steve Reid <st...@edmweb.com> > 100% Public Domain > > Zhenxu Ke <kezhenx...@apache.org>于2023年2月14日 周二10:00写道： > >> Hi, sorry the mailer-dae...@apache.org just says it can't deliver my >> email, which should be sent out last night (2023/02/13 22:49), here is my >> reply: >> >> Hi, now I would continue to vote -1 and I believe this should be fixed >> ASAP, because you might copy the file[1] from Redis, but the file is not >> originated from Redis either, it’s copied from yet another project >> valgrind[2], which is GPL licensed[3]. >> >> [1] incubator-kvrocks/src/common/sha1.cc >> [2] https://github.com/danos/valgrind/blob/master/none/tests/sha1_test.c >> [3] https://github.com/danos/valgrind/blob/master/COPYING >> >> On 2023/02/14 00:43:19 tison wrote: >>> Hi Justin, >>> >>> It can be a case of The Ship of Theseus. When you take a look at the >> issued >>> files[1][2], you may find a commit history touching them and modifying >>> them. Anyway, it's not an identical copy or one-shot translation. And we >>> keep the origin comments. >>> >>> Even a one-shot translation, if it's done by humans, generally >> modification >>> will be applied. >>> >>> But if you insist on "keep the original license header and don't add the >>> ASF header" with an existing documented guideline, the Kvrocks >> contributors >>> would be glad to change it. >>> >>> Best, >>> tison. >>> >>> [1] >>> >> https://github.com/apache/incubator-kvrocks/commits/unstable/src/types/geohash.cc >>> [2] >>> >> https://github.com/apache/incubator-kvrocks/commits/unstable/src/common/sha1.cc >>> >>> >>> Justin Mclean <jus...@classsoftware.com> 于2023年2月14日周二 05:39写道： >>> >>>> Hi, >>>> >>>> In general porting a file from one language to another would not change >>>> the original license. >>>> >>>> Kind Regards, >>>> Justin >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >>>> For additional commands, e-mail: general-h...@incubator.apache.org >>>> >>>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> -- > Best, > tison. --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
