Hi sorry -1 (binding) due to license issue, the following files [1] have ASF license headers along with the original license header, I saw you mentioned it's a conversion from C to C++ from Redis project, but from my comparison they look to be mostly the same so you might want to remove the ASF license header from those files.
Other files [2] might be controversial whether we should have dual license headers, but I won't vote -1 on those files if [1] are resolved. [1] - apache/incubator-kvrocks/src/types/geohash.cc <http://geohash.cc/> - apache/incubator-kvrocks/src/common/sha1.cc <http://sha1.cc/> [2] - src/common/rand.cc src/common/rand.h - src/storage/scripting.* > On Feb 11, 2023, at 22:43, Myth <caipen...@apache.org> wrote: > > Hello Incubator PMC, > > The Apache Kvrocks community has voted and approved the release of Apache > Kvrocks(incubating) 2.3.0. We now kindly request the IPMC members review > and vote for this release. > > This is the second call for a vote. The first call for a vote, which is > cancelled: > *https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt > <https://lists.apache.org/thread/pbfmd81pfqrzjvqzb194o6dxlynt5gwt>* > > Kvrocks is a distributed key value NoSQL database that uses RocksDB as the > storage engine and is compatible with Redis protocol. The current release > provides many new features, many improvements and fixes many bugs. > > Kvrocks community vote thread: > https://lists.apache.org/thread/o4rl21ckhmo5d594xvksl4l8djf0ctm2 > > Vote result thread: > https://lists.apache.org/thread/o335chgmyfrplcvys3lobtdwdk29kmjw > > The release candidate: > https://dist.apache.org/repos/dist/dev/incubator/kvrocks/2.3.0/ > > This release has been signed with a PGP available here: > https://downloads.apache.org/incubator/kvrocks/KEYS > > Git tag for the release: > https://github.com/apache/incubator-kvrocks/releases/tag/v2.3.0 > > Docker image: > https://hub.docker.com/layers/caipengbo/kvrocks/2.3.0/images/sha256-78f1d29e632e94fc438d71174285e1034418fb06eb8b623a93bc0a15451b6807 > > Build guide can be found at: > https://github.com/apache/incubator-kvrocks#build > > The vote will be open for at least 72 hours or until the necessary number > of votes is reached. > > Please vote accordingly: > [ ] +1 Approve the release of Apache Kvrocks(incubating) 2.3.0 > [ ] +0 > [ ] -1 Do not approve (please specify the reason) > > Thanks --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
