That's a good point: all depends on how we consider md files: if we consider md files as source (documentation), and it's included in the source distribution, the ASF header should be there.
I prefer to include ASF header in md files as I consider it as source. Regards JB On Tue, Aug 26, 2025 at 3:53 AM tison <wander4...@gmail.com> wrote: > > +1 binding > > [x] Download links are valid. > [x] Checksums and signatures. > [x] LICENSE/NOTICE/DISCLAIMER files exist > [x] No unexpected binary files > [x] All source files have ASF headers > > To @JB: > > I don't have a strong feeling about the license header on markdown > files if they are docs. I can see [1] as a previous example. Some > projects add the header to md files and it's surely OK. > > [1] https://github.com/apache/openoffice/pull/394#issuecomment-3152219776 > > The Apache License 2.0 clearly includes documentation source as one of > the "Source" [2]. > > [2] https://www.apache.org/licenses/LICENSE-2.0 > > So I wonder if we have a written document about how to do with md > files? AFAICS many ASF projects don't apply the license header to md > files. > > [x] Can compile from source > > Best, > tison. > > Calvin Kirs <k...@apache.org> 于2025年8月26日周二 09:28写道： > > > > Hi Ed, > > > > Thank you for helping with the review. > > > > MIT License has no requirements regarding the NOTICE file, and we have > > retained the original copyright and license statements. I think this is > > enough. > > > > On Tue, Aug 26, 2025 at 7:15 AM Ed Espino <esp...@apache.org> wrote: > > > > > Vote: 0 > > > > > > As a new IPMC member, I'm taking a conservative approach to provide > > > feedback for the project team to consider. > > > > > > Issues identified: > > > > > > 1. NOTICE file missing required third-party attributions for bundled > > > components: > > > > > > - mini-yaml (MIT License) > > > - Copyright(c) 2018 Jimmie Bergmann > > > - Location: cpp/thirdparty/mini-yaml/ > > > - Used in: cpp/src/graphar/graph_info.cc and cpp/src/graphar/yaml.cc > > > - License file: licenses/LICENSE-mini-yaml.txt > > > > > > - result (MIT License) > > > - Copyright (c) 2017-2021 Matthew Rodusek > > > - Location: cpp/thirdparty/result/result.hpp > > > - Used in: cpp/src/graphar/fwd.h > > > - License file: licenses/LICENSE-result.txt > > > > > > - simple-uri-parser (MIT License) > > > - Copyright (c) 2021 Jonathan Hollocombe > > > - Location: cpp/thirdparty/simple-uri-parser/uri_parser.h > > > - Used in: cpp/src/graphar/filesystem.cc > > > - License file: licenses/LICENSE-simple-uri-parser > > > > > > - cpplint (BSD-3-Clause) > > > - Copyright (C) 2009 Google Inc. > > > - Location: cpp/misc/cpplint.py > > > - Used as build tool in CMakeLists.txt and CI pipeline > > > - License file: licenses/LICENSE-cpplint.txt > > > > > > While all components have their respective license files properly > > > included in the licenses/ directory, the MIT and BSD-3-Clause licenses > > > require copyright notices to be "included in all copies or substantial > > > portions of the Software." Apache policy > > > (https://www.apache.org/legal/src-headers.html#notice) implements this > > > requirement through the NOTICE file for bundled third-party > > > components. > > > > > > 2. CHANGELOG.md appears outdated - last entry is v0.11.4 from > > > 2024-03-27, but this is version 0.13.0. > > > > > > Items validated: > > > - [X] Download links are valid > > > - [X] Checksums and signatures verified > > > - [X] LICENSE/NOTICE files exist > > > - [X] No unexpected binary files found > > > - [X] All source files have ASF headers > > > - verified using Hawkeye: docker run --rm -v > > > "$(pwd)":/github/workspace ghcr.io/korandoru/hawkeye:v4 check > > > - [X] Can compile from source on Rocky Linux 9: > > > - C++ components: cd cpp && cmake -S . -B build && cmake --build build > > > - Spark components: cd maven-projects/spark && mvn clean compile > > > -DskipTests > > > > > > The project demonstrates good license discipline overall. These are > > > administrative fixes that should be straightforward to address. > > > > > > On Sun, Aug 24, 2025 at 10:28 PM Xiaokang <xiaok...@apache.org> wrote: > > > > > > > > Hello Incubator PMC, > > > > > > > > The Apache GraphAr community has voted and approved the release of > > > > Apache > > > > GraphAr(incubating) 0.13.0-rc.1. We now kindly request the IPMC members > > > > review and vote for this release. > > > > > > > > Apache GraphAr(incubating) is an open-source and language-independent > > > data > > > > file format designed for > > > > efficient graph data storage and retrieval. > > > > > > > > GraphAr community vote thread: > > > > > > > > https://lists.apache.org/thread/tmht7kqcvhl88b1s219966jtzo1mxqqy > > > > > > > > Vote result thread: > > > > > > > > https://lists.apache.org/thread/3nnv6do732nykmq0stkjdshfcghpf4tc > > > > > > > > The release candidate: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/graphar/0.13.0-rc.1/ > > > > > > > > This release has been signed with a PGP available here: > > > > > > > > https://downloads.apache.org/incubator/graphar/KEYS > > > > > > > > Git tag for the release: > > > > > > > > https://github.com/apache/incubator-graphar/releases/tag/v0.13.0-rc.1 > > > > > > > > Please download, verify, and test. > > > > > > > > The VOTE will be open for at least 72 hours and until the necessary > > > > number of votes are reached. > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > To learn more about apache graphar, please see > > > https://graphar.apache.org/ > > > > > > > > Checklist for reference: > > > > > > > > [ ] Download links are valid. > > > > [ ] Checksums and signatures. > > > > [ ] LICENSE/NOTICE files exist > > > > [ ] No unexpected binary files > > > > [ ] All source files have ASF headers > > > > [ ] Can compile from source > > > > > > > > More detailed checklist please refer to: > > > > https://github.com/apache/incubator-graphar/tree/main/scripts > > > > > > > > To compile from source, please refer to: > > > > https://graphar.apache.org/community/development > > > > > > > > Thanks > > > > > > > > Xiaokang Yang > > > > > > > > > > > > -- > > > Ed Espino > > > Apache Cloudberry (Incubating) & MADlib > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > -- > > Best wishes！ > > CalvinKirs > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
