Hi JB, Thank you very much for your detailed review and the thorough check of our 2.1.0-rc1.
> -- LICENSE and NOTICE are good. nit: in the LICENSE file there is a > typo: licenses/licenses/LICENSE-isc.txt instead of licenses/LICENSE-isc.txt > (double licenses) Good catch! We appreciate you spotting this. This is indeed a typo in the doc. > - cloudberry backup > -- No binary/compiled file found. NB: can you clarify if the tar.gz files > located in end_to_end/resources are required ? These files are required for our end-to-end integration tests. They are compressed formats of plain text data used as test resources. We prefer to keep them for test but will add explicit clarifications in a `README.apache.md` or similar documentation in future versions. > - cloudberry pxf > -- No compiled files. NB: the source distribution includes a few gz files > (tweets.tar.gz, ...). Also gradle-wrapper.jar should not be part of the > source distribution Similar to the above, these .gz files are also test files in compressed plain text format. For gradle-warpper.jar, we will see how to deal with it for better compliance without affecting the program building & running. > Just to be clarify: > 2. in cloudberry-backup, it's not clear to me where the go files are coming > from (the LICENSE mentions Greenplum, but doesn't list the go files). It > seems that the go files need the ASF header. You are correct. These Go files originated from the Greenplum project. Sorry for not explicitly listing them in a more detailed list in the `LICENSE`. BTW, would you recommend we cancel this RC and prepare RC2 to address these issues specifically, or would it be acceptable to include these fixes in the next release? We are prepared to roll out RC2 if you believe these points are blockers for the current vote. Thank you again for your guidance! Best, Dianjin Wang --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
