> tokio - semaphore/mod.rs, semaphore/tests.rs, once/once_cell/mod.rs After another look, I should update the HISTORY.md file because the semaphore and once_cell have been rewritten. They are different from tokio's implementation now.
Best, tison. tison <[email protected]> 于2026年9月4日周五 11:07写道： > > This code is mine, so I resubmit it as the original copyright owner. It > should be fine. > > Maybe an IP clearance process helps. But it is no more than about one > thousand lines of code written by me. > > Let me know if an IP clearance process would be preferred. > > Best, > tison. > > > tison <[email protected]> 于2026年9月4日周五 11:01写道： > >> Hi Justin, >> >> > fastpool - pool/mod.rs, pool/bounded.rs >> >> This code is mine, so I resubmit it as the original copyright owner. It >> should be fine. >> >> > - LICENSE is missing 3rd-party code included in the release >> > - some files incorrectly have ASF headers >> >> This is relevant, but I need to tell more details about the history. >> >> > Tokio - mutex/mod.rstokio, rwlock/mod.rs, rwlock/read_guard.rs, >> write_guard.rs, mapped_read_guard.rs, mapped_write_guard.rs, >> owned_read_guard.rs, owned_write_guard.rs, owned_mapped_read_guard.rs, >> owned_mapped_write_guard.rs >> > tokio - semaphore/mod.rs, semaphore/tests.rs, once/once_cell/mod.rs >> > oneshot crate - oneshot/mod.rs, receiver.rs, sender.rs, tests.rs >> > futures-rs - internal/atomic_waker.rs >> > pollster, futures-lite - blocking/mod.rs >> > parking - blocking/parker.rs >> >> These are not purely third-party code. Most of them are reimplemented >> (mainly simplified to narrow down to the crate's necessity). Some of them >> are mostly derived, but still depend on different internal primitives. >> >> So I think a co-existing license header should be fine. And yes, the >> LICENSE file should include those references, while all of them can be >> use under ALv2. >> >> > I think there are likely other 3rd-party code not mentioned in >> HISTORY.md, given how the code was created. >> >> Why? I know where they come from. >> >> Best, >> tison. >> >> >> Justin Mclean <[email protected]> 于2026年9月4日周五 10:44写道： >> >>> Hi, >>> >>> -1 (binding) due to LICENSE and file header issues >>> >>> I checked: >>> - incubating in artifact name >>> - DISCLAIMER exists >>> - LICENSE is missing 3rd party code included in teh release >>> - NOTICE is fine >>> - some files incorrectly have ASF headers >>> - I did not compile from source >>> >>> 3rd party code includes: >>> Tokio - mutex/mod.rstokio, rwlock/mod.rs, rwlock/read_guard.rs, >>> write_guard.rs, mapped_read_guard.rs, mapped_write_guard.rs, >>> owned_read_guard.rs, owned_write_guard.rs, owned_mapped_read_guard.rs, >>> owned_mapped_write_guard.rs >>> fastpool - pool/mod.rs, pool/bounded.rs >>> >>> HISTORY.md and file headers also point to other 3rd-party code included: >>> tokio - semaphore/mod.rs, semaphore/tests.rs, once/once_cell/mod.rs >>> oneshot crate - oneshot/mod.rs, receiver.rs, sender.rs, tests.rs >>> futures-rs - internal/atomic_waker.rs >>> pollster, futures-lite - blocking/mod.rs >>> parking - blocking/parker.rs >>> >>> I think there are likely other 3rd-party code not mentioned in >>> HISTORY.md, given how the code was created. >>> >>> Again, I'll point out that the automation used here didn't find any of >>> this. On the dev list vote, nearly everyone said LICENSE, NOTICE, and >>> DISCLAIMER were present. Present isn't the required check. Someone has to >>> read LICENSE against what's actually in the archive. >>> >>> Kind regards, >>> Justin >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>>
