I found some 3rd party code in the source release that is not mentioned in the license. Otherwise, the source release looks ok.
The convenience binaries also have some license issues. None of the issues are blockers but hopefully, they can be reviewed soon. I've raised the issues in your issue tracker. I'm currently a 0 binding but may vote +1 if you need the extra vote. On 2026/11/07 07:17:15 Ed Espino via general wrote: > +1 approve (binding) > > Checklist for reference. These passed. > > - Download links are valid > - Checksums and signatures > - LICENSE/NOTICE/DISCLAIMER files > - No unexpected binary files in the source release > - All source files have ASF headers > - Can compile from source > > The notes below are additional checks. They do not change that result. > > For a later release: > > LICENSE-binary points at licenses/LICENSE.xmlenc-0.52, licenses/LICENSE.asm, > and licenses/LICENSE.xz.txt. Those files are in licenses-binary/. The text is > present. A later release can correct the path. > > ---------------------------------------- > Podling vote > ---------------------------------------- > > The podling vote on [email protected] passed. Result: > https://lists.apache.org/thread/1xp4ccn7p8t867f4wkq5cydhco8sdbvm > Vote: https://lists.apache.org/thread/fkp7q5r3ctjdj7c2kbdndjy963zy308v > The result mail reported 3 binding PPMC +1 and no -1. The artifacts named > there are the ones in this vote. I am not treating that tally as my own > review. > > The podling subject is "[VOTE] Release Apache Amoro (incubating) 0.9.0 RC14". > This call is "[VOTE] Release Apache Amoro (incubating) 0.9.0-incubating". The > dist URL, tag, and commit are the same. > > ---------------------------------------- > Source archives > ---------------------------------------- > > Checked each with its .asc and .sha512, staged at > https://dist.apache.org/repos/dist/dev/incubator/amoro/0.9.0-incubating-RC14/ > > - apache-amoro-0.9.0-incubating-src.tar.gz > - apache-amoro-0.9.0-incubating-bin-hadoop2.tar.gz > - apache-amoro-0.9.0-incubating-bin-hadoop3.tar.gz > > - SHA-512 matched on all three. > - Good signature on all three, from the key this vote names, id suffix > BE102BE7. The key is not certified on this machine. That warning is not a bad > signature. > - incubating is in all three filenames. > - The source tar matches git tag v0.9.0-rc14. No content differences. No > unexpected archive-only files. > - No AppleDouble files in the source tar. Those are the ._ sidecars a Mac > packer writes beside a real file. > - Each binary tar unpacks to amoro-0.9.0-incubating and has LICENSE, NOTICE, > and DISCLAIMER. > - Hadoop 2 tar: 428 jars. Hadoop 3 tar: 394 jars. > > ---------------------------------------- > License and headers > ---------------------------------------- > > - LICENSE, NOTICE, and DISCLAIMER are present. > - Header check: ./mvnw apache-rat:check, pom plugin 0.15, pom excludes. Exit > 0. 33 modules. Unapproved 0. > - No compiled files in the source archive (.class, .jar, .so, .o). > - LICENSE names ICU, SparkInternalRowWrapper, and ThreadLocalCache. > - Three SparkInternalRowWrapper.java files. One ThreadLocalCache.java. > - LICENSE-binary names activation, jaxb, servlet, javassist, dnsjava, xmlenc > 0.52, Kyuubi, and the ongres SCRAM and Stringprep pieces inside the > PostgreSQL jar. > - xmlenc is listed there as BSD-3-Clause, which is the note in this call. > > ---------------------------------------- > Build and Unit Tests > ---------------------------------------- > > The vote points to the validation guide for these steps: > https://amoro.apache.org/validate-release/ > > That page's compile command is ./mvnw clean package. It runs the unit tests. > I ran that, with -B so Maven does not prompt. > > - Command: ./mvnw -B clean package > - Java 11.0.25, JAVA_HOME /usr/lib/jvm/java-11-openjdk > - BUILD SUCCESS > - Total time: 29:36 min. Finished 2026-11-06 22:20:00 -08:00 > - Failures: 0. Errors: 0. The suite skipped some tests. A skip is not a > failure. > > ---------------------------------------- > Staged Maven files > ---------------------------------------- > > https://repository.apache.org/content/repositories/orgapacheamoro-1093 > > Checksums passed. SHA-1 matched for 31 main jars and 35 poms. This repository > does not publish SHA-512. The dist files above do. > > I compared class files to an earlier compile. I am not treating that > difference as a defect in the source archive. > > ---------------------------------------- > Build host > ---------------------------------------- > > This is the host I compiled on. > > OS: Rocky Linux 9.8 (Blue Onyx) > Architecture: x86_64 > vCPU and class: 16, c7i.4xlarge > Java: OpenJDK 11.0.25, JAVA_HOME /usr/lib/jvm/java-11-openjdk > AMI recipe: > https://github.com/edespino/cloudberry-image-factory/tree/main/vm-images/aws/cloudberry/build/rocky9 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
