On Sun, 2 Jan 2005, sebb wrote:
On Sat, 1 Jan 2005 19:50:10 -0500 (EST), Henri Yandell <[EMAIL PROTECTED]> wrote:
I've fixed the various spacing issues in the XSLT system (over time the Anakia style sheet changed slightly) and as far as I can tell it looks the same.
BTW, the source files don't look the same - but that is an advantage, as the Anakia output was not all that well laid out.
The XSLT version is a bit of a pain in that it's not doing newlines; I think it's quite easy to get them to stay I just need to remember how.
I spent a lot of time hacking the html pages in debugging to find out that not having the DOCTYPE at the top causes some weird spacing issues :)
If the old version is needed however, it is tagged under the tag PRE-ANAKIA-REMOVAL.
If anyone can take a look and see if they can see problems, I'd appreciate it a lot. New years day means not a lot of users looking compared to usual (though also not a lot of committers around to check etc).
I've not noticed any visible browsing errors in a brief check. The JMeter binary and source links work fine.
However, the <base> tags have disappeared from the binindex and sourceindex output.
I don't know if these are required or not - could it be that some mirror sites require them?
If they are not required, that is an advantage, as it means that internal page links work much quicker. Dunno why, but it seems that the base tag causes intermal links to be treated as being on a new page, so the whole lot is reloaded...
I'd been wondering why that was happening.
There's nothing in either the comment history for either site.vsl or binindex.xml to imply that the base was put in for any special reason.
However, Stefan Bodewig added the functionality for base tags into site.vsl in 1.27 with a comment of:
Enable downloads via mirrors
which suggests that it's probably important.
I'll get it added back in, #1 priority. In fact, I'll hack it by hand first and figure out how to xsl it second :)
Another difference on the downloads pages (at least) is that the meta tags aren't closed. The Anakia stylesheet used to close these by including a trailing /; looks like the XSL version never did.
Perhaps it should?
Bizarre that they're not closed given that XSL has to be XML compliant. I'll look into fixing this, lesser priority.
Thanks,
Hen
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
