> > Especially the "if (!retsmi)" is very > > hard to follow. > > Is it hard to follow ?
It doesn't follow the convention of returning 0 if success, non-zero if failure -- the only way I could know that !retsmi means something other than "success" is if I go read the comment that tells me "0 if the SMP should be completed up the stack," and there's no reason why I would go search for that comment. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
