> Quoting Michael S. Tsirkin <[EMAIL PROTECTED]>: > Subject: Re: [PATCH 2/2] IB/iser: add backport & kernel > addons?foropen-iscsiover iSER support for RHAS4 up3 and up4 > > > Quoting Erez Zilber <[EMAIL PROTECTED]>: > > Subject: Re: [PATCH 2/2] IB/iser: add backport & kernel > > addons?foropen-iscsiover iSER support for RHAS4 up3 and up4 > > > > > > >> I have the following files in backport/2.6.9_UX/include/src/: > > >> > > >> attribute_container.c - almost identical to the file on 2.6.20. I had to > > >> change one line in it. > > >> > > > > > > could be a patch ... > > > which line? > > > > > > > > Now, attribute_container.c, klist.c & transport_class.c are copied from > > the kernel tree. I've committed the required changes in > > ~erezz/ofabuild_iser_rh4.git & ~erezz/ofed_1_2_iser_rh4.git. > > git fetch git://git.openfabrics.org/~erezz/ofed_1_2_iser_rh4.git. > fatal: The remote end hung up unexpectedly > Cannot get the repository state from > git://git.openfabrics.org/~erezz/ofed_1_2_iser_rh4.git. > > > > The main > > change is a new dir called "kernel_addons_patches". It contains patches > > for kernel tree files in order to create the required addons from them. > > sorry, but I really don't think we can touch build scripts at this point. > Doing cp in build scripts is also a problem since it interferes with > development (there are 2 places to edit each file). > And adding kernel version dependency there is also really messy.
BTW, one important principle is that *all* information about the kernel build process must be contained inside kernel tree. Keeping lists of files in an external tree is *evil*. > Suggestion: why can't these patches be part of the regular backport directory? > > you copy stuff to include/src and then include it, but this just looks > like and unnecessary extra step. Can't we include the source file from > it original place directory, like this: > #include "../drivers/base/attribute_container.c" -- MST _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
