Overall idea looks good... one comment: > + if (n->dev->flags & IFF_MASTER) { > + /* n->dev is not an IPoIB device and we have > + to take priv from elsewhere */ > + neigh = *to_ipoib_neigh(n); > + if (neigh) { > + priv = netdev_priv(neigh->dev); > + ipoib_dbg(priv, "neigh_destructor for bonding device: > %s\n", > + n->dev->name); > + } else > + return; > + }
seems like it would be cleaner not to worry about bonding here and just use neigh->dev all the time rather than having two ways to look up the device. _______________________________________________ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general