Actually, thinking about this some more... would it be cleaner to more
the knowledge about bonding out of the ipoib driver? in other words,
export something similar to
> +static int ipoib_slave_detach(struct net_device *dev)
> +{
> + int ret = 0;
> + if (dev->flags & IFF_SLAVE) {
> + dev->priv_flags |= IFF_SLAVE_DETACH;
> + rtnl_lock();
> + ret = call_netdevice_notifiers(NETDEV_CHANGE, dev);
> + rtnl_unlock();
> + }
> + return ret;
> +}
for drivers to use, rather than putting use of IFF_SLAVE and
IFF_SLAVE_DETACH outside of the bonding driver.
Also it seems this function could return void, since both call sites
ignore the return value and I don't see anything sensible that IPoIB
could do with the notifier chain return value anyway.
- R.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
