On Thu, Jun 26, 2008 at 5:55 PM, Eli Cohen <[EMAIL PROTECTED]> wrote: > On Thu, 2008-06-26 at 14:35 +0000, Ron Livne wrote: >> Index: kernels/linux-2.6.26-rc2/drivers/infiniband/ulp/ipoib/ipoib_verbs.c >> =================================================================== >> --- kernels.orig/linux-2.6.26-rc2/drivers/infiniband/ulp/ipoib/ipoib_verbs.c >> 2008-06-26 14:10:01.000000000 +0300 >> +++ kernels/linux-2.6.26-rc2/drivers/infiniband/ulp/ipoib/ipoib_verbs.c >> 2008-06-26 14:10:20.000000000 +0300 >> @@ -153,7 +153,8 @@ int ipoib_transport_dev_init(struct net_ >> .max_recv_sge = IPOIB_UD_RX_SG >> }, >> .sq_sig_type = IB_SIGNAL_ALL_WR, >> - .qp_type = IB_QPT_UD >> + .qp_type = IB_QPT_UD, >> + .create_flags = 0 >> }; > Why do you need to set create_flags explicitly? > >> >> int ret, size; >> @@ -201,7 +202,10 @@ int ipoib_transport_dev_init(struct net_ >> init_attr.recv_cq = priv->recv_cq; >> >> if (priv->hca_caps & IB_DEVICE_UD_TSO) >> - init_attr.create_flags = IB_QP_CREATE_IPOIB_UD_LSO; >> + init_attr.create_flags |= IB_QP_CREATE_IPOIB_UD_LSO; > > and change this too?
The reason is that I wanted to return all the creation flags for the QP. So I set it to 0 in case no creation flag was used, not just IB_QP_CREATE_IPOIB_UD_LSO as it was. Notice that I also added: + if (priv->hca_caps & IB_DEVICE_BLOCK_LOOPBACK) + init_attr.create_flags |= IB_QP_CREATE_MULTICAST_BLOCK_LOOPBACK; for the creation flag I added. Ron _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
