> > + .create_flags = 0 > Why do you need to set create_flags explicitly?
right, that's redundant, since missing initializer fields are always cleared to 0. > > - init_attr.create_flags = IB_QP_CREATE_IPOIB_UD_LSO; > > + init_attr.create_flags |= IB_QP_CREATE_IPOIB_UD_LSO; > and change this too? this doesn't seem that bad a change to me. It is defensive against later changes adding something else to create_flags earlier on in the function, and it is also nice to be uniform with the block loopback flag. So I'll leave this in. - R. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
