>>> +#if 1 >>> + mad_rpc_close_port(srcport); >>> +#else >>> umad_unregister(port, agent); >>> umad_close_port(port); >>> umad_done(); >>> +#endif >> >> Why use "#if 1" here? Why not just replace the umad calls with >> mad_rpc_close_port? > >Just consistency with what's been done in other places in that file. >Other similar places are ifdef'd so I kept that.
My vote is to not add an #if 1 and keep dead code around. If #if 1 appears in other places, we should probably remove that dead code as well. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
