On Wed, Mar 11, 2009 at 4:54 PM, Sean Hefty <[email protected]> wrote: >>>> +#if 1 >>>> + mad_rpc_close_port(srcport); >>>> +#else >>>> umad_unregister(port, agent); >>>> umad_close_port(port); >>>> umad_done(); >>>> +#endif >>> >>> Why use "#if 1" here? Why not just replace the umad calls with >>> mad_rpc_close_port? >> >>Just consistency with what's been done in other places in that file. >>Other similar places are ifdef'd so I kept that. > > My vote is to not add an #if 1 and keep dead code around. If #if 1 appears in > other places, we should probably remove that dead code as well.
Someone made the decision to want to be able to switch back and forth earlier. This should be directed to them. It's certainly easy to eliminate the old code. _______________________________________________ general mailing list [email protected] http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
