2008/10/13 Alin Dreghiciu <[EMAIL PROTECTED]> > I will have to revert your patch. > Actually the problem is that the the option is "classPath" not > "classpath" (capital P). > Now we can argue that is not very intuitive and error prone, fact that I > agree. > So, if you change the option to "classPath" it should work. > Alternatively you can use the other shortcut witch is similar to > classPath named "cp". > > So guys, what do you say: shall I change the --classPath option to > classpath? I guess it will eliminate future problems like this and is > less confusing. The only downside I see that some people already uses > that. > Actually a simpler solution is to use both -classpath and --classPath. >
+1 for classpath and classPath as I didn't spot that either... actually, perhaps make argument names case-insensitive? > On Sat, Oct 11, 2008 at 3:41 PM, Stefano Kismet Lenzi > <[EMAIL PROTECTED]> wrote: > > On Sat, Oct 11, 2008 at 13:28, Stuart McCulloch <[EMAIL PROTECTED]> > wrote: > >> 2008/10/11 Stefano Kismet Lenzi <[EMAIL PROTECTED]> > >>> > >>> Hi Stuart, > >>> > >>> I have added the a line with "--log=DEBUG" and I found out that the > >>> classpath option is not applied, in fact the resulting command line > >>> taken from the mvn max:run ouput is: > >>> Start command line [[/usr/lib/jvm/java-6-openjdk//bin/java, > >>> > >>> -Dfelix.config.properties=file:/home/kismet/Projects/ > isti.cnr.it/proximity/sail.driver.sad/runner//felix/config.ini, > >>> > >>> -Dfelix.cache.dir=/home/kismet/Projects/ > isti.cnr.it/proximity/sail.driver.sad/runner/felix/cache, > >>> > >>> > -Dorg.osgi.framework.bootdelegation=org.apache.commons.*,org.apache.log4j.*,com.martiansoftware.*,com.thoughtworks.*,edu.uci.ics.*, > >>> -cp, > >>> /home/kismet/Projects/ > isti.cnr.it/proximity/sail.driver.sad/runner/bundles/org.apache.felix.org.apache.felix.main_1.2.1.jar > , > >>> org.apache.felix.main.Main]] > >>> > >>> I wonder way that happens, could it be a problem with pax-runner > >>> classpath option handling itself? In fact I have tried to run the > >>> SNAPSHOT version of pax-runner from command line and if start it with > >>> --log=DEBUG and --classpath=<something> I get a "Start command line" > >>> with the wrong classpath. > >>> > >>> I further investigate and it seems that the classpath acquired by the > >>> OptionResolverImpl class but it never copied to PlatformImpl which is > >>> the class in charge of starting the new JVM. I have created a patch > >>> which doesn't pass the TestSuite but it actually works (I have tested > >>> by disabling the test in mvn). > >>> > >>> I hope that we can help you to fix the problem. > >> > >> I'm not up to speed on how pax-runner processes the various options > >> for the platform builder, so I can't say if this is the "right" solution > - > >> will > >> have to wait for Alin to take a look > > > > No problem at all :) > > > >> > >> btw, if you've signed up on JIRA then you should automatically have > >> commit rights, which means you could go ahead and commit it now > >> (please also open a JIRA issue for the original problem, and use it > >> in the commit message) > > > > I have opened the issue PAXRUNNER-168 > > > >> > >> at OPS4J we don't like patches - just commit directly, as everyone > >> will get notified of the change (in diff form) and can act accordingly > >> > > > > I have also applied the patch with commit r12951 > > > > _______________________________________________ > > general mailing list > > general@lists.ops4j.org > > http://lists.ops4j.org/mailman/listinfo/general > > > > > > -- > Alin Dreghiciu > http://www.ops4j.org - New Energy for OSS Communities - Open > Participation Software. > http://www.qi4j.org - New Energy for Java - Domain Driven > Development. > http://malaysia.jayway.net - New Energy for Projects - Great People > working on Great Projects at Great Places > > _______________________________________________ > general mailing list > general@lists.ops4j.org > http://lists.ops4j.org/mailman/listinfo/general > -- Cheers, Stuart
_______________________________________________ general mailing list general@lists.ops4j.org http://lists.ops4j.org/mailman/listinfo/general
