[ 
http://issues.ops4j.org/browse/PAXURL-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757#action_13757
 ] 

Andreas Pieber commented on PAXURL-95:
--------------------------------------

ok, I've figured it out... The problem is you've changed the behaviour 
completely. I understand y you have done this but well, this breaks a lot... 
IMHO we have two options: 

a) pack this issue into pax-web-2.0.0 (or 1.3; not so sure, about the pax; 
versioning schema here); 
b) set the use-fallback repositories to true per default. Well, this still 
changes the behavior, but I cant imagine a way how this can break any 
builds/projects using pax-url

I personally would vote for option b...

WDYT?

btw.: the patch would look like (I haven't commited it by now since it breaks 
the pax-url tests and I want to discuss this first):

-> % git diff
diff --git 
a/pax-url-maven-commons/src/main/java/org/ops4j/pax/url/maven/commons/MavenConfigurationImpl.java
 b/pax-url-
index 34adfc5..23c3861 100644
--- 
a/pax-url-maven-commons/src/main/java/org/ops4j/pax/url/maven/commons/MavenConfigurationImpl.java
+++ 
b/pax-url-maven-commons/src/main/java/org/ops4j/pax/url/maven/commons/MavenConfigurationImpl.java
@@ -316,6 +316,11 @@ public class MavenConfigurationImpl
     {
         if( !contains( m_pid + 
MavenConstants.PROPERTY_USE_FALLBACK_REPOSITORIES ) )
         {
+          if(m_propertyResolver.get( m_pid + 
MavenConstants.PROPERTY_USE_FALLBACK_REPOSITORIES ) == null) {
+            return set( m_pid + 
MavenConstants.PROPERTY_USE_FALLBACK_REPOSITORIES,
+                        true            );
+
+          }
             return set( m_pid + 
MavenConstants.PROPERTY_USE_FALLBACK_REPOSITORIES,
                         Boolean.valueOf(
                             m_propertyResolver.get( m_pid + 
MavenConstants.PROPERTY_USE_FALLBACK_REPOSITORIES )


> Removal of DEFAULT_REPOSITORIES commit produces strange behavior in testing
> ---------------------------------------------------------------------------
>
>                 Key: PAXURL-95
>                 URL: http://issues.ops4j.org/browse/PAXURL-95
>             Project: Pax URL
>          Issue Type: Bug
>    Affects Versions: 1.2.2, 1.2.3
>            Reporter: Andreas Pieber
>            Assignee: Andreas Pieber
>             Fix For: 1.2.4
>
>
> Current master produces strange errors in karaf like:
> a) not finding felix-main-3.0.1
> b) trying to find org.eclipse.osgi/org.eclipse.osgi although its 
> org.eclipse/osgi
> Reverting 
> https://github.com/ops4j/org.ops4j.pax.url/commit/cf43d9aea89ea12f1ea7f7fcfaef172906198fe9
>  fixes the problem; but well, actually this is no solution (IMHO)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.ops4j.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

_______________________________________________
general mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/general

Reply via email to