On Tue, 2013-02-26 at 13:04 -0500, W. Trevor King wrote: > On Tue, Feb 26, 2013 at 08:47:14AM -0800, Brian Dolbec wrote: > > Also I've rebased everything on current master > > That should make things easier to merge :). > > It looks like some of my earlier comments were addressed by this > reroll, but some are still applicable. Apologies if we'd resolved any > of this earlier and I just missed the reference in my mailbox. > > I map my old comments onto the rebased commits below, but the bulk of > the outstanding suggestions revolve around: > > * ConfigParser-based configuration > * Argparse-based command line parsing > * Logging-based debugging output > * os.path.join(), normpath(), … for path manipulation > > These are mostly “take advantage of Python's standard library” > changes, and I'd be happy to help implement them on top of the current > master if folks feel like that has a chance of getting merged ;). >
All that is for a TODO list. What I did was rebase my existing changes, merging fixes to the commits that made the change..., fix the commit messages, etc... Same with the other things you listed below, mostly for a TODO and your wishlist. Pretty much all I agree with. My aim for now is to debug the hell out of it, to stabilize all the existing changes, BEFORE doing a ton more changes. That will also give me more experience in how catalyst is used, possibly ideas how to change it for the better. I'll fix the doc's generation and make a setup.py and new 9999 ebuild. Plus I need to focus more on another project needed for the git tree migration. > Cheers, > Trevor >
