On Tue, Feb 26, 2013 at 06:04:54PM -0800, Brian Dolbec wrote: > I tried using git to send this patch, but it did not work. I'll look > into how to make it work with email. > … > I will continue to spam the list with all my rebased commits, which I > intended to do when I had more time. I sent this one off this morning > before I went to work. I know Jorge was interested in the changes. I'm > back now, so will manually prepare more patch mails.
It looks like you're pasting diffs into your email client, which makes
it harder for others to apply them with `git am`. When I'm submitting
patches via email, I usually do something like:
$ git format-patch --cover-letter -v3 -o my-fix $(git merge-base my-fix
master)
$ emacs my-fix/v3-0000-cover-letter.patch
… fill in subject and summarize changes since v2 …
$ git send-email --to [email protected] \
--in-reply-to '<[email protected]>' my-fix/v3-*
Where `my-fix` is the name of my feature branch. The `-v3` option
requires Git ≥1.8.2 for -v/--reroll-count, before that you had to use
something like `--subject-prefix 'PATCH v3'` [1].
By default, `send-email` will try and send the emails with `sendmail`.
If you don't have a working version of sendmail installed, you can
configure it to use SMTP instead [2,3].
By using the format-patch/send-email pair, you avoid copy/paste errors
and tedium. You also have author information and commit messages
preserved in a form that `git am` understands. Wins for everybody ;).
Cheers,
Trevor
[1]: http://kernel.org/pub/software/scm/git/docs/git-format-patch.html
[2]: http://kernel.org/pub/software/scm/git/docs/git-send-email.html
[3]: http://kernel.org/pub/software/scm/git/docs/git-config.html
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
