On Sat, Dec 14, 2013 at 06:56:23PM -0800, Brian Dolbec wrote:
> On Sat, 2013-12-14 at 14:24 -0800, W. Trevor King wrote:
> > +           "port_tmpdir": "/var/tmp/portage",
> 
> But, isn't this ridiculous.  I was even chastised before for adding
> something that wasn't used right away. I consequently had to rebase
> it away.

Sure.  I don't think we use settings['port_tmpdir'] in this part of
the series though.  I can shift this commit back to the next phase if
folks think that's appropriate.

> -                       self.mounts = ["proc", "dev", "distdir", 
> "/var/tmp/portage"]
> +                       self.mounts = ["proc", "dev", "distdir", 
> "port_tmpdir"]
>                         self.mountmap = {"proc":"/proc", "dev":"/dev", 
> "/dev/pts":"/dev/pts",\
> -                               
> "distdir":self.settings["distdir"],"/var/tmp/portage":"tmpfs"}
> +                               "distdir":self.settings["distdir"], 
> "port_tmpdir":"tmpfs"}

This is changing the *mountmap key* to port_tmpdir, but it's not
changing the *mount target*.  I'm not sure where that happens, maybe
it's automatically extracted from settings using the mountmap key?

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to