On Sat, Dec 14, 2013 at 07:07:57PM -0800, W. Trevor King wrote:
> On Sat, Dec 14, 2013 at 06:56:23PM -0800, Brian Dolbec wrote:
> > -                       self.mounts = ["proc", "dev", "distdir", 
> > "/var/tmp/portage"]
> > +                       self.mounts = ["proc", "dev", "distdir", 
> > "port_tmpdir"]
> >                         self.mountmap = {"proc":"/proc", "dev":"/dev", 
> > "/dev/pts":"/dev/pts",\
> > -                               
> > "distdir":self.settings["distdir"],"/var/tmp/portage":"tmpfs"}
> > +                               "distdir":self.settings["distdir"], 
> > "port_tmpdir":"tmpfs"}
> 
> This is changing the *mountmap key* to port_tmpdir, but it's not
> changing the *mount target*.  I'm not sure where that happens, maybe
> it's automatically extracted from settings using the mountmap key?

Oops, I mean't “mount source” not “mount target” :p.  I grepped
through the rest of rewrite-on-master, and I don't see
settings["port_tmpdir"] anywhere.  Perhaps we should just drop this
commit?

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to