On Mon, 30 Dec 2013, Brian Dolbec wrote:
On Sat, 2013-12-28 at 19:52 -0800, W. Trevor King wrote:
On Sat, Dec 28, 2013 at 06:49:11PM -0800, W. Trevor King wrote:
On Sat, Dec 28, 2013 at 05:57:09PM -0800, Brian Dolbec wrote:
- self.mounts.append("/tmp/stage1root/proc")
- self.mountmap["/tmp/stage1root/proc"]="/proc"
+ self.mounts.append("stage1root/proc")
+ self.target_mounts["stage1root/proc"] = "/tmp/stage1root/proc"
+ self.mountmap["stage1root/proc"]="/proc"
Hmm. I'm not how this is handled at the moment, but don't we want:
mount -t proc none /tmp/stage1root/proc
instead of:
mount --bind /proc /tmp/stage1root/proc
The handbook is currently using --rbind as well [1].
Maybe food for a future series :p.
After Douglas Freed talked me off the devtmpfs ledge on
#gentoo-releng, my current suggested mount changes are:
-t:
proc
--rbind:
sys
dev
portdir
port_logdir
port_tmpdir
kerncache
ccache
icecream
drop:
devpts (now that we --rbind /dev)
distdir (now that we --rbind portdir)
packagedir (now that we --rbind portdir)
For distdir/packagedir, I'd be find if the source defaulted to None
(meaning “don't mount anything”) but could be configured to a path
(meaning “--rbind this after you've --rbind-mounted portdir”).
Cheers,
Trevor
No, we can't drop distdir and packagedir. The default locations for
those are waiting for the catalyst changes to be completed. That is the
reason I got started rewriting catalyst a year ago. Those 2 directories
are being relocated OUT of the tree. Like they should have been all
along.
As I've already mentioned on #gentoo-releng, there are also 2 reasons this
is a no-go for me:
1. it's unlikely we want to share pkgdir between the host and the targets
we build
2. sharing pkgdir between incompatible targets would fail miserably. For
example, skimmer does amd64 builds for hardened and non-hardened, multilib
and no-multilib. It also does x86 builds. Sharing a package between any or
at least most of those targets would fail and cause broken stages.
Regards,
Jorge
