On Sat, Dec 28, 2013 at 05:57:07PM -0800, Brian Dolbec wrote:
> Fixes commit 463d98fe94041313e0cb4497081858ab5d9121f3

In the Git history (git://github.com/gitster/git.git) the convention
seems to be:

  ${SHORT_HASH} (${SUBJECT}, ${AUTHOR_DATE})

so:

  Fixes commit 463d98f (modules/generic_stage_target.py: Use a
  'local_overlay' setting instead of hard-coding '/usr/local/portage',
  2012-12-19).

The benefits of including human-readable content are:

* Folks don't have to look up the hash to get an idea about the
  referenced commit's changes.
* If this commit is cherry-picked into an alternate history, the
  subject and author-date will be preserved, but the hash changes.

>       confdefaults = {
>               "distdir": "/usr/portage/distfiles",
>               "hash_function": "crc32",
> +             "local_overlay": "/usr/local/portage",

Oops :p.  Looks good to me.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to