On Sat, Jan 11, 2014 at 11:45:23AM -0800, Brian Dolbec wrote:
> diff --git a/targets/stage1/stage1-controller.sh
> b/targets/stage1/stage1-controller.sh
> index 3671095..d38ac73 100755
> --- a/targets/stage1/stage1-controller.sh
> +++ b/targets/stage1/stage1-controller.sh
> @@ -14,7 +14,7 @@ case $1 in
> install -d ${clst_chroot_path}/${clst_root_path}/etc/portage
>
> # Setup make.conf and make.profile link in "ROOT in chroot":
> - copy_to_chroot ${clst_chroot_path}/etc/portage/make.conf
> /${clst_root_path}/etc/portage
> + copy_to_chroot ${clst_chroot_path}/etc/portage/make.conf
> ${clst_root_path}/etc/portage
This looks good to me. clst_root_path should always be an absolute
path, and I can get through stage1 with this patch applied. However,
shouldn't the previous few lines be:
# Setup "ROOT in chroot" dir
install -d ${clst_chroot_path}${clst_root_path}/etc
install -d ${clst_chroot_path}${clst_root_path}/etc/portage
Without the extra slash between clst_chroot_path and clst_root_path?
I'm fine with leaving those for a separate patch if we just want to
apply this one as-is.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc
Description: OpenPGP digital signature
