On Monday 06 August 2007, Petteri Räty wrote: > Mike Frysinger kirjoitti: > > On Saturday 04 August 2007, Petteri Räty wrote: > >> Steev Klimaszewski kirjoitti: > >>> Vlastimil Babka wrote: > >>>> dodoc calls should have || die and USE=doc should be tested before > >>>> commiting a bump, IMHO > >>> > >>> Sorry, I didn't realize my 3 hour compile of $APPLICATION should die > >>> because TODO wasn't around. Vote against || die - it doesn't affect > >>> anything aside from misc docs not being installed, if its really that > >>> important, most people hit the website anyway. (But yes, they should > >>> be corrected and tested before committing) > >> > >> And is the average ebuild 3 hours and haven't you heard about FEATURES > >> noauto? The || die is there for maintainers to spot when version > >> bumping. If you commit a version that's broken with missing TODO and || > >> die you should think about if you are doing everything right... > > > > so you think everyone should be an ebuild ninja and know exactly how to > > recover ? or edit an ebuild to fix the issue themselves (you're assuming > > dodoc was the last statement in src_install, not the first) > > -mike > > Yes, every gentoo dev with gentoo-x86 access should know how to deal > with it.
we're not talking developers, we're talking users. it's inappropriate for a user to have spent significant time compiling a package only to have it fail because TODO does not exist. -mike
signature.asc
Description: This is a digitally signed message part.