On 06:22 Mon 24 Sep , Thilo Bangert wrote:
> do people fix the stuff that is pointed out to them?
Yep, I've seen a lot of fixes for reviews.
> also, perhaps the more common ones should additionally be converted to
> repoman tests, if that is feasable.
That might be reasonable for some cases, but it won't be perfect, and
won't even be possible for many.
So far, the only one I've seen that might work well for is quoting
around specific variables. You could do something like a grep for words
containing '${+D[^[:alnum:]-_]' (haven't tested that, just beginnings of
an idea) and the same for S and WORKDIR.
Thanks,
Donnie
--
[EMAIL PROTECTED] mailing list
