-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Donnie Berkholz wrote:
> On 12:35 Mon 24 Sep , Marijn Schouten (hkbst) wrote:
>> hkbst 07/09/24 12:35:11
>>
>> Modified: ChangeLog
>> Added: bigloo-3.0b_p2.ebuild
>> Log:
>> bump 3.0b-2, minor bugfix version
>> (Portage version: 2.1.3.9)
>
>> # "make test" does something weird so default src_test() in
>> /usr/lib/portage/bin/ebuild.sh fails the following test
>> # elif emake -j1 test -n &> /dev/null; then
>> # so copy straight from default src_test() all the stuff which depends on
>> that test passing
>> src_test() {
>> vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
>> if ! emake -j1 test; then
>> hasq test $FEATURES && die "Make test failed. See above for
>> details."
>> hasq test $FEATURES || eerror "Make test failed. See above for
>> details."
>> fi
>> }
>
> I'm a bit confused about what's going on here. Isn't src_test() only
> supposed to run when 'test' is in FEATURES?
I'm not sure, but as the comment says, I copied this straight from
/usr/lib/portage/bin/ebuild.sh and it goes:
src_test() {
if emake -j1 check -n &> /dev/null; then
vecho ">>> Test phase [check]: ${CATEGORY}/${PF}"
if ! emake -j1 check; then
hasq test $FEATURES && die "Make check failed. See
above for details."
hasq test $FEATURES || eerror "Make check failed. See
above for details."
fi
elif emake -j1 test -n &> /dev/null; then
vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
if ! emake -j1 test; then
hasq test $FEATURES && die "Make test failed. See
above for details."
hasq test $FEATURES || eerror "Make test failed. See
above for details."
fi
else
vecho ">>> Test phase [none]: ${CATEGORY}/${PF}"
fi
}
Marijn
PS Thank you for reviewing, Donnie.
- --
Marijn Schouten (hkBst), Gentoo Lisp project
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFG+OdHp/VmCx0OL2wRApSBAKCCw8MZPTXuKlbswqYhKxKKrVlggQCgw2FM
OLDCy2QA4DV2tJFED2OFZt4=
=JAnZ
-----END PGP SIGNATURE-----
--
[EMAIL PROTECTED] mailing list
