On Tuesday 25 September 2007 12:47:35 Marijn Schouten (hkBst) wrote:
> > > # "make test" does something weird so default src_test() in
> > > /usr/lib/portage/bin/ebuild.sh fails the following test
> > > # elif emake -j1 test -n &> /dev/null; then
> > > # so copy straight from default src_test() all the stuff which depends on
> > > that test passing
> > > src_test() {
> > > vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
> > > if ! emake -j1 test; then
> > > hasq test $FEATURES && die "Make test failed. See above for
> > > details."
> > > hasq test $FEATURES || eerror "Make test failed. See above for
> > > details."
> > > fi
> > > }
> >
> > I'm a bit confused about what's going on here. Isn't src_test() only
> > supposed to run when 'test' is in FEATURES?
>
> I'm not sure, but as the comment says, I copied this straight from
> /usr/lib/portage/bin/ebuild.sh and it goes:
[SNIP]
Some of that code is unreachable since src_test is never called when test is
not in FEATURES. Also there is some dispute as to whether testing the FEATURES
variable at all is permitted in ebuilds (bug #174335). In either case it's not
needed here. if `emake -j1 test -n` really fails for some reason even though
`emake -j1 test` generally works your src_test should just be:
src_test() {
emake -j1 test || die "Make test failed"
}
--
Bo Andresen
signature.asc
Description: This is a digitally signed message part.
