Doug Goldstein wrote: > I know the other thing I didn't answer was the fact that some variables > aren't quoted. It doesn't matter at all considering their configure > script can't handle spaces in the path names anyway. We've been though > that already. Additionally, qmake can't handle spaces in there even if > you do quote so it really doesn't matter much. > I disagree: it's important to do the correct thing, wrt spaces in filenames, in scripts, since there is a well-understood method of doing so (quoting) and once it is correct, it is always correct no matter what use is made of it in the future. If upstream tools can't deal with them, then they need to be fixed. I appreciate that might not happen for this configure script, but it shoud happen for qmake. (I find it hard to believe that qmake can't deal with spaces in filenames tbh, not from experience: it just sounds amateurish.)
> Some of these review changes truly feel like working at a company where > you know the ins and outs of your tool. You can rattle off its > capabilities to a millimeter. A new boss/manager comes in and has no > idea what the tool is or the mission but by god he knows how to do your > job better and you will follow his procedures. It makes no difference if > his steps have no effect on the tool and waste more of your time. You > additionally have to start giving him progress reports on how you're > doing using his procedures, which instantly means you get less work done. > > That's what this commits review list feels like. Fair enough: that's how you feel about it. The quoting issue isn't new though[1]: that it hasn't been picked up on before is no excuse for not fixing it now, imo. The tool in question is bash, not the upstream configure script or qmake, and correct usage should be a point of pride: again, only my opinion. Then again, no-one's making you report back-- you're not under any contractual obligation to respond: must just be professional pride? ;-) [1] http://www.grymoire.com/Unix/Quote.html http://bash-hackers.org/wiki/doku.php?id=syntax:words explains why and how the issue arises. -- [EMAIL PROTECTED] mailing list
