-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Wulf C. Krueger schrieb: > On Friday, 09. November 2007 10:10:42 René 'Necoro' Neumann wrote: >> But as I think, that the uppercase version is the common behavior here, >> it should not need this extra "PYTHON". :) That's why the patch ;) > > Actually, the mixed-case is what we have encountered in most cases. > > Furthermore, as you stated correctly yourself, cmake is case-sensitive and > a patch that works around that fact only to have one parameter less for a > function doesn't really make much sense in my book. > Hmm ... ok - if you say, that more applications used the mixed case versions, the current version is ok :) I did not want to reduce one parameter, but when I first used this eclass function, I assumed, that it will do the right thing (that is: make it uppercase). It did not do so - that's why the patch ;).
Another way would be to enhance the comment and state explicitly that it takes the useflag literally and does not do any case transition :) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHNIZt4UOg/zhYFuARAhuNAJ97EaX5W2ffNUrtPsFLLY1ZzTQFFQCffyCE mThno69KazBAWmnsifjxM8E= =7Xbk -----END PGP SIGNATURE----- -- [EMAIL PROTECTED] mailing list
