* Torsten Veller <ml...@veller.net>:
> Please review the attached perl-module.eclass.
> Patch linked below.

Thanks Bo Ørsted Andresen for feedback

> Changes
> ~~~~~~~
  - use emake
  - more quoting
  - call perlinfo only once

As I've not seen any ebuild doing the replacement in line 156,
I've added a temporary ewarn. If you hits you, tell me.

> git://github.com/tove/perl-eclass.git
> http://people.gentoo.org/tove/files/perl-module.eclass.diff
# Copyright 1999-2004 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/eclass/perl-module.eclass,v 1.112 2008/09/30 
08:28:44 robbat2 Exp $
#
# Author: Seemant Kulleen <seem...@gentoo.org>

# @ECLASS: perl-module.eclass
# @MAINTAINER:
# p...@gentoo.org
# @BLURB: eclass for perl modules
# @DESCRIPTION:
# The perl-module eclass is designed to allow easier installation of perl
# modules, and their incorporation into the Gentoo Linux system.

inherit eutils base

case "${EAPI:-0}" in
        0|1)
                EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst pkg_prerm 
pkg_postrm src_compile src_install src_test src_unpack
                ;;
        *)
                EXPORT_FUNCTIONS src_unpack src_prepare src_configure 
src_compile src_test src_install
                ;;
esac

DESCRIPTION="Based on the $ECLASS eclass"

LICENSE="${LICENSE:-|| ( Artistic GPL-2 )}"

[ -z "${SRC_URI}" -a -z "${MODULE_A}" ] && MODULE_A="${MY_P:-${P}}.tar.gz"
[ -z "${SRC_URI}" -a -n "${MODULE_AUTHOR}" ] && \
        
SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION}/${MODULE_A}"
[ -z "${HOMEPAGE}" ] && \
        HOMEPAGE="http://search.cpan.org/dist/${MY_PN:-${PN}}";

SRC_PREP="no"
SRC_TEST="skip"
PREFER_BUILDPL="yes"

PERL_VERSION=""
SITE_ARCH=""
SITE_LIB=""
VENDOR_LIB=""
VENDOR_ARCH=""
ARCH_LIB=""
pm_echovar=""
perlinfo_done=false

perl-module_src_unpack() {
        base_src_unpack unpack
        has "${EAPI:-0}" 0 1 && perl-module_src_prepare
}

perl-module_src_prepare() {
        if [[ -n ${PATCHES} ]] ; then
                base_src_unpack autopatch
        fi
        esvn_clean
}

perl-module_src_configure() {
        perl-module_src_prep
}

perl-module_src_prep() {
        [[ "${SRC_PREP}" = "yes" ]] && return 0
        SRC_PREP="yes"

        ${perlinfo_done} || perlinfo

        export PERL_MM_USE_DEFAULT=1
        # Disable ExtUtils::AutoInstall from prompting
        export PERL_EXTUTILS_AUTOINSTALL="--skipdeps"

        if [[ "${PREFER_BUILDPL}" == "yes" && -f Build.PL ]] ; then
                einfo "Using Module::Build"
                perl Build.PL \
                        --installdirs=vendor \
                        --libdoc= \
                        --destdir="${D}" \
                        --create_packlist=0 \
                        --extra_linker_flags="${LDFLAGS}" \
                        ${myconf} \
                        <<< ${pm_echovar} \
                                || die "Unable to build! (are you using 
USE=\"build\"?)"
        elif [[ -f Makefile.PL ]] ; then
                einfo "Using ExtUtils::MakeMaker"
                perl Makefile.PL \
                        PREFIX=/usr \
                        INSTALLDIRS=vendor \
                        INSTALLMAN3DIR='none' \
                        DESTDIR="${D}" \
                        ${myconf} \
                        <<< ${pm_echovar} \
                                || die "Unable to build! (are you using 
USE=\"build\"?)"
        fi
        if [[ ! -f Build.PL && ! -f Makefile.PL ]] ; then
                einfo "No Make or Build file detected..."
                return
        fi
}

perl-module_src_compile() {
        ${perlinfo_done} || perlinfo

        has "${EAPI:-0}" 0 1 && perl-module_src_prep

        if [[ -f Build ]] ; then
                ./Build build || die "compilation failed"
        elif [[ -f Makefile ]] ; then
                #emake ${mymake} OPTIMIZE="${CFLAGS}" OTHERLDFLAGS="${LDFLAGS}" 
|| die "compilation failed"
                emake ${mymake} OTHERLDFLAGS="${LDFLAGS}" || die "compilation 
failed"
        fi
}

perl-module_src_test() {
        if [[ "${SRC_TEST}" == "do" ]] ; then
                ${perlinfo_done} || perlinfo
                if [[ -f Build ]] ; then
                        ./Build test || die "test failed"
                elif [[ -f Makefile ]] ; then
                        emake test || die "test failed"
                fi
        fi
}

perl-module_src_install() {
        local f
        ${perlinfo_done} || perlinfo

        [[ -z ${mytargets} ]] && mytargets="pure_install"

        if [[ -f Build ]] ; then
                ./Build ${mytargets} || die
        elif [[ -f Makefile ]] ; then
                emake ${myinst} ${mytargets} || die
        fi

#       einfo "Cleaning out stray man files"
        find "${D}" -type f -name "*.3pm" -delete
        find "${D}"/usr/share/man -depth -type d -empty -delete 2>/dev/null

        fixlocalpod

        for f in Change* CHANGES README* ${mydoc}; do
                [[ -s "${f}" ]] && dodoc ${f}
        done

        find "${D}/${VENDOR_LIB}" -type f -a \( -name .packlist \
                -o \( -name '*.bs' -a -empty \) \) -delete
        find "${D}/${VENDOR_LIB}" -depth -mindepth 1 -type d -empty -delete

        find "${D}" -type f -not -name '*.so' | while read f ; do
                if file "${f}" | grep -q -i " text" ; then
if grep -q "${D}" "${f}" ; then ewarn "QA: File contains a temporary path ${f}" 
; fi
                        sed -i -e "s:${D}:/:g" "${f}" || die
                fi
        done
}

perl-module_pkg_setup() {
        ${perlinfo_done} || perlinfo
}

perl-module_pkg_preinst() {
        ${perlinfo_done} || perlinfo
}

perl-module_pkg_postinst() { : ; }
#       einfo "Man pages are not installed for most modules now."
#       einfo "Please use perldoc instead."
#}

perl-module_pkg_prerm() { : ; }

perl-module_pkg_postrm() { : ; }

perlinfo() {
        perlinfo_done=true

        local f version install{site{arch,lib},archlib,vendor{arch,lib}}
        for f in version install{site{arch,lib},archlib,vendor{arch,lib}} ; do
                eval "$(perl -V:${f} )"
        done
        PERL_VERSION=${version}
        SITE_ARCH=${installsitearch}
        SITE_LIB=${installsitelib}
        ARCH_LIB=${installarchlib}
        VENDOR_LIB=${installvendorlib}
        VENDOR_ARCH=${installvendorarch}
}

fixlocalpod() {
        find "${D}" -type f -name perllocal.pod -delete
        find "${D}" -depth -mindepth 1 -type d -empty -delete
}

Reply via email to